Git Product home page Git Product logo

Comments (4)

joaopbnogueira avatar joaopbnogueira commented on June 4, 2024

Hi,

Is this issue being addressed by anyone?

I'm working on a fix, but it won't be backwards-compatible with the current version.

The solution requires a change of interface in the MapVersionedODataRoutes methods to something like:

public static IReadOnlyList<ODataRoute> MapVersionedODataRoutes(this HttpConfiguration configuration, string routeName, string routePrefix, Action<IContainerBuilder> configureAction, IEnumerable<IEdmModel> models)

Thanks

from aspnet-api-versioning.

commonsensesoftware avatar commonsensesoftware commented on June 4, 2024

Unfortunately, it's just been me and I've been tied up with other priorities; primarily my day job. I'm a strong advocate and consumer of OData, so being able to move past 5.9.1 to 6.0+ is something I definitely want to see happen.

From my cursory examination, I know that support for 6.0+ won't be backward compatible. There are significant breaking changes in the OData library. It's unfortunate that the changes are breaking, but the from what I've seen, I'm pleased with the changes they've made; I think it's in the right direction.

I believe you're right, most of the changes are in the related MapVersionedODataRoutes. Since DI has now been introduced with first-class support, I'm not even sure these methods are required anymore. They were needed to change the behaviors of how routing was setup, including behaviors like conventions, casing, etc. I believe that most or all of these aspects can now be changed via the DI support.

I'll see if I can dedicate some time this week. If you have anything to show or share, I'm more than happy to take a look.

from aspnet-api-versioning.

joaopbnogueira avatar joaopbnogueira commented on June 4, 2024

from aspnet-api-versioning.

joaopbnogueira avatar joaopbnogueira commented on June 4, 2024

Have a look at my latest commit here

  • With the exception of VersionedMetadataRoutingConventionTest.cs all tests pass on Microsoft.AspNet.OData.Versioning.Tests
  • I'm not sure how to reference types "MetadataPathSegment/EntitySetPathSegment", or if the tests still make sense.

from aspnet-api-versioning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.