Exceptions from RemoteExecutorHost should get into XML log about arcade HOT 8 CLOSED

Maybe throwinfg XunitException(message) with the message being the actual exception?

from arcade.

@safern that would terminate the test but tests can expect exceptions from the remote process (https://github.com/dotnet/corefx/blob/master/src/System.Runtime.Extensions/tests/System/AppDomainTests.cs#L94) so they wouldn't want that

I think what needs to be done is

1. capture the console output from the spawned process
2. write it to XUnit.ITestOutputHelper so it goes to the XML log (generally we don't use this interface because we want it to write ot the console also, but in this case we are already getting that)
3. rely on the test setting RemoteInvokeOptions.CheckExitCode = true or otherwise determining by itself that the child process died unexpectedly.

from arcade.

I'm not sure how feasible this is with the official xunit runner.

from arcade.

Is this anything more than modifying RemoteExecutor.Invoke here (https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.RemoteExecutor/src/Microsoft.DotNet.RemoteExecutor/RemoteExecutor.cs#L247) to accept an ITestOutputHelper thing and capture the StdOut/StdErr from the process into it?

from arcade.

@ViktorHofer ?

from arcade.

Microsoft.DotNet.RemoteExecutor is currently only tied to xunit in a few places to do an assert. Ideally we would not add more dependency and instead get rid of its dependency so that it can be used outside of xunit.

from arcade.

This issue is over a year old. Is there something actionable here that says we should keep it open?

from arcade.

Closing given no activity or responses.

from arcade.