Git Product home page Git Product logo

Comments (1)

mmitche avatar mmitche commented on July 19, 2024

Probably Darc is looking at the target branch's file rather than the PR branch's file.

Yes, Maestro is reading from the target branch initially when creating the branch, and either it keeps looking at the target branch, or it has a list of previously updated packages and only uses those for future updates. Can't remember which.

We can probably make a partial fix by reading dependencies from the PR branch if an existing PR is already open. A 'full' fix would be more difficult. A common scenario that happens is that a PR is opened for updates, someone adds a new dependency in a different PR, and both PRs merge. Often they don't conflict so you can get incoherency that way. Maestro would need to be aware of the PR target branch's current state and ensure that the dependency set wasn't changed. If it was, then it needs to restart the update process, pulling in a new build.

from arcade-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.