Git Product home page Git Product logo

Comments (9)

chcosta avatar chcosta commented on August 18, 2024 1

.net cli supports "local" global tools.

from arcade-services.

mmitche avatar mmitche commented on August 18, 2024

@chcosta This is an interesting scenario. Where does the darc tool get installed in this case? I'm not sure what the expected behavior is, since this is a dotnet global tool. Maybe the dotnet toolset needs to make it on the PATH?

Or maybe dotnet global tools don't work at all if the sdk isn't on the PATH. @livarcocc What is the expected behavior if you:

  • Didn't have the dotnet SDK on the path
  • Explicitly called some SDK to install a tool
  • Called the tool.

from arcade-services.

markwilkie avatar markwilkie commented on August 18, 2024

@livarcocc - curious if you have thoughts here

from arcade-services.

mmitche avatar mmitche commented on August 18, 2024

Darc is not really local to a repo, it just happens to be rolled out that way. You could install it "locally". but as soon as you clean your enlistment, darc will be gone. I think "local" is more confusing tbh.

Anyways, I don't think a fix for this is required for p2.

from arcade-services.

chcosta avatar chcosta commented on August 18, 2024

The rest of Arcade follows the pattern that if you're running locally, then you install things globally (default) and this helps with things like package restores such; if you're running in ci, then packages are installed locally, this prevents machine wide state issues. It'd be great to follow a similar pattern with darc.

It's confusing to have this thing that is delivered with Arcade but doesn't use or follow any of the Arcade conventions (including CLI version)

Agreed, I don't think this is required for p2.

from arcade-services.

mmitche avatar mmitche commented on August 18, 2024

@chcosta It's actually no longer delivered with arcade (aside from install script).

from arcade-services.

chcosta avatar chcosta commented on August 18, 2024

I think that's my main concern though. The perception is that, since you get the install script from Arcade (eng/common), that it follows Arcade conventions. Perhaps this shouldn't be delivered via Arcade?

from arcade-services.

mmitche avatar mmitche commented on August 18, 2024

Maybe we should just not have it bootstrap the dotnet toolset all all and require a global toolset? The install script can still be delivered via arcade. It's just looking up the correct version to use and doing a dotnet tool install

from arcade-services.

nkolev92 avatar nkolev92 commented on August 18, 2024

I created this related issue yesterday, dotnet/arcade#3744

On NuGet side we're basically writing a release definition that bootstraps darc, and then does a add-build-to-channel and trigger subscriptions.

from arcade-services.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.