Would it be possible to use an external prompt, such as startship? about shell HOT 8 CLOSED

Latest release will fix the issue

from shell.

Done a quick test and replacing the existing prompt handler with this seems to work fine.

Shell.Prompt = () =>
    var prompt = `starship prompt --status=$Shell.LastExitCode$ --jobs=$Shell.BackgroundProcesses.Count()$`;
    return ColorString.FromRawANSI(prompt);
};

from shell.

I appreciate you taking the time to look into this. I tried swapping out the default for your example, but for some reason, I keep getting the following:

zsh > dotnet-shell
An error occured loading core.nsh
StartIndex cannot be less than zero. (Parameter 'startIndex')
# >

I tried to add a few slight checks, but I still end up getting the same result:

// bool? powerline = null;
#region c#
Shell.Prompt = () =>
{
    var exitCode = `Shell.LastExitCode`;
    if (exitCode == null || exitCode < 0)
    {
        exitCode = 0;
    }

    var bgJobs = `Shell.BackgroundProcesses.Count()`;
    if (bgJobs == null || bgJobs < 0)
    {
        bgJobs = 0;
    }

    var prompt = `starship prompt --status=$exitCode$ --jobs=$bgJobs$`;
    return ColorString.FromRawANSI(prompt);
};

// Shell.Prompt = () =>
#endregion
// {
//       if (powerline == null && !RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
//       {
//           var powerlineHelpOut=`which powerline`;
//           powerline = !string.IsNullOrWhiteSpace(powerlineHelpOut);
//       }

//       if (powerline == true)
//       {
//           string powerLinePrompt=`powerline-render shell left --last-exit-code=$Shell.LastExitCode$`;
//           return new ColorString("!", Color.Green, Color.LightBlue) + ColorString.FromRawANSI( powerLinePrompt );
//       }
//       else
//       {
//           return new ColorString("!" + Environment.UserName + "@" + Environment.MachineName, Color.Green) + new ColorString(" " + Shell.WorkingDirectory + ">", Color.Blue) + " ";
//       }
// };

I just edited core.nsh directly. It seemed like that would be the proper way to go about it, am I mistaken on that?

Thanks,
-MH

from shell.

There are problems:
var exitCode = `Shell.LastExitCode`; should actually be var exitCode = Shell.LastExitCode;
Putting text in backticks means execute this shell command, take the stdout and put in a variable. But Shell.LastExitCode is already a piece of C# -- see LastExitCode. That means we can just assign it.

Same for the bgJobs variable assigned as well - drop those backticks.

bgJobs and exitCode will also never be null or < 0 so you can drop that check as well.

When executing the starship prompt helper you are correctly using $VARIABLE$ notation so that dotnet-shell knows to replace that text with a variable held in C#.

Make those changes and your code should work.

My guess is that you getting that error as some bash error message is being evaluated when starship is run. Personally I would stick with my code, it works and its a bit more concise.

from shell.

Ah yes, that definitely makes sense. Unfortunately, though, the original code you had shared is what was giving the An error occured loading core.nsh. StartIndex cannot be less than zero. (Parameter 'startIndex') message. That was the reason I tried to check to make sure one of the values weren't coming back as less than 0. The error message didn't change, though between the original code you shared and the modification I had tried.

from shell.

This is my core.nsh that i've just tested on Ubuntu and works. Could I ask that you give this a go. If there is still a bug there is a much more exciting issue.

from shell.

I have reproduced the issue. The dotnet-shell preprocess isn't taking out all the comments correctly. Removing the large comment blog (as in my paste) will fix your issue.

from shell.

I was just in process of typing that out, you beat me to it. 👍

from shell.