Cleanup job removes not expired tokens about doorkeeper HOT 1 OPEN

Hello @jensljungblad

I don't think there is an issue with this, could you provide a failing test that proves your point?

In Expirable, expires_at is computed as created_at + expires_in.
In StaleRecordsCleaner#clean_expired, ttl is basically the same as expires_in.

so we have:

created_at < (Time.current - expires_in)
VS
Time.now.utc > (created_at + expires_in)

And these 2 statements are equivalent. (I only have a doubt about Time.current vs Time.now.utc, I guess it's fine as long as you have UTC configured as a time zone)

from doorkeeper.