Comments (2)
This would tidy things up, thanks for the suggestion!
from gitsome.
Unfortunately, #90 solves this issue incorrectly. Among other things, if the user doesn't have XDG_CONFIG_HOME
set in their shell environment, the path expands to /<config_file_name>
, which should bomb with an error because gh
won't be able to write to that location (and it shouldn't write anything there).
The correct approach would define a configuration search path for each configuration <file>
. The path for *nix users would be:
$XDG_CONFIG_HOME/gitsome/<file>
~/.config/gitsome/<file>
, assuming~/.config
exists and$XDG_CONFIG_HOME
is unset- fall back to
~/.gitsome/<file>
The technically appropriate places on Windows and OS X are, respectively, %APPDATA%\gitsome\<file>
and ~/Library/Application Support/gitsome/<file>
but given the nature of this app I think you can get away with just calling it ~/.gitsome/<file>
(i.e. user's home directory).
One thing I do believe (and is reflected in the above pathing suggestions) is that, rather than having multiple dotfiles in the user's home directory, they should be grouped in a dotdir, i.e. .gitsome/
. This lets you store whatever you need to in that directory without cluttering $HOME
.
Also, I am of the opinion that if gitsome
is installed in a virtual environment (i.e., $VIRTUAL_ENV
or %VIRTUAL_ENV%
is set), its configuration data should live in that environment. Or at least, the user should have the option to specify that configuration files outside the virtual environment can be overridden by config files the virtual environment. I may be the only one who cares about this last bit, though ¯_(ツ)_/¯.
I'd be happy to implement all of this if ya'll are interested.
from gitsome.
Related Issues (20)
- EEL issue HOT 1
- command errored out with exit status 1: python setup.py egg_info check the logs for full command output HOT 2
- No module named 'prompt_toolkit.key_binding.manager' HOT 1
- Error when Running pip install : python setup.py egg_info
- conflict between `gh` command name between gitsome and official GitHub client HOT 2
- python setup.py egg_info Check the logs for full command output.
- Kali Linux - Problem HOT 1
- should pyzmq be listed in setup.py or requirements,txt?
- I am unable to install hdbscan for a project
- prompt-toolkit HOT 1
- Feedparser AttributeError in Python 3.9 HOT 1
- error: pip3 install gitsome --upgrade
- bad interpreter: /usr/local/opt/python/bin/python3.7: no such file or directory
- Mark as archived
- Missing `f` prefix on f-strings
- installation of gitsome throws spurious warning HOT 1
- Configuring gitsome with an ssh-key HOT 1
- # [Codecov](https://codecov.io/gh/donnemartin/gitsome/pull/131?src=pr&el=h1) Report
- Unable to install opencv-python at ubuntu 18.04 using dockerfile
- `feedparser=5.2.1` does not support the latest version of `setuptools` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitsome.