Comments (6)
Preliminary PR for this here: #33
from dunet.
I think this is a great idea. It would also work nicely when we add generic support since we cannot infer generic types with constructors.
from dunet.
I think #17 addresses this use case with a more superior implementation due to more control over the union members' types. What do you think @mumby0168 ?
from dunet.
I think #17 addresses this use case with a more superior implementation due to more control over the union members' types. What do you think @mumby0168 ?
Hi yes I like this, no reason the root record, the Result in the example cannot contain factory methods also. I.e Results.Ok() with the need of the new keyword, it could follow the same pattern with a bool to indicate you want the extra methods generating.
What do you think?
from dunet.
Hi yes I like this, no reason the root record, the Result in the example cannot contain factory methods also. I.e Results.Ok() with the need of the new keyword, it could follow the same pattern with a bool to indicate you want the extra methods generating.
What do you think?
I'm having a hard time seeing a generated factory method like Result.Ok()
playing nicely with #17 also providing a way to instantiate that same union member with new Result.Ok()
or Result.NewOk()
due to name collisions. I'm inclined to prioritize the implementation of #17, and then reassessing how we feel about this issue after that.
from dunet.
After some more analysis, I'm going to defer this feature for the following reasons:
- The ability of users to write
Foo.NewThing()
rather thannew Foo.Thing()
is not worth the increase in complexity and potential maintenance burden to this library. - Source generators already have a steep learning curve, due to a lot of hidden/non-explicit behavior. I believe a successful source generator should do as much as it can to minimize such behavior and take an explicit approach whenever possible. This feature runs counter to that philosophy.
- With #28 on the docket, constructors and factory methods will not be necessary for most use cases. This is because users will be able to assign inner union values directly to the union type. This will bring Dunet unions in line with most other language's DU implementations and effectively obsolete constructors and factory methods. For example:
// No need for constructor or factory methods to instantiate union values.
StringOrNumber str = "foo";
StringOrNumber num = 123;
[Union]
partial record StringOrNumber
{
partial record Str(string Value);
partial record Num(double Value);
}
If the community remains interested in this feature, I would whole-heartedly support a separate package containing this functionality. I'd also be glad to link to it from Dunet's readme if that becomes the case.
from dunet.
Related Issues (20)
- Record struct union support HOT 8
- Anonymous union variants
- Match on a specific union value only
- Unwrap union types HOT 2
- Simplify instantiation of generic-bound union members HOT 1
- Idea: Friendly use of ToString() HOT 4
- Make common members accessible without matching HOT 4
- Allow matching with static functions
- Implicit conversions clash with required union properties HOT 1
- Separate Attributes into another project HOT 4
- Question: make it to work with asp net HOT 6
- Prefer `_ is _ _` pattern HOT 1
- Add Action with the type in the else of a MatchXYZ HOT 7
- Annotate Generated Code with GeneratedCodeAttribute
- Inner union compile with error `Cannot implicitly convert type 'X' to 'Y` HOT 6
- Async match support HOT 2
- Add `Action` based `Match` (or similarly named) method HOT 5
- Async Action Match
- Do not generate implicit conversions if argument is an interface
- Disable CS1591 in generated code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dunet.