[QUESTION] Duplicate variables about graphql-combine-query HOT 4 OPEN

Here are some ideas:

• The add function could always rename the variables and add a postfix, e.g. id -> id_0 to avoid collision
• Accept "global variables" in the combineQuery function and use them in all queries

from graphql-combine-query.

I combine queries with combineQuery function + add and I don't pass variables there, I pass them in apollo's useQuery afterwards like this:

// query.js file
const queries = []; // some imported queries here, that use common variables
const getQuery= () => {
  let combinedQuery = combineQuery("Query");
  queries.forEach((query) => (combinedQuery = combinedQuery.add(query)));

  return combinedQuery.document;
};
const query = getQuery();


// inside some component
const {loading, error, data} = useQuery(query, { // imported query here
    variables: {...someVariables},
  });

And after that I get duplicate variable definition variable for operations Query1 and Query2 error.

Does anyone know a workaround to fix this?

from graphql-combine-query.

I solved this issue with fragments without graphql-combine-query lib, like was mentioned here: apollographql/graphql-tag#169 (comment)

const oneQuery = gql`
    query Query(
      $variable: String!
    ) {
      ...firstFragment
      ...secondFragment
    }
    ${firstFragment}
    ${secondFragment}
  `;

from graphql-combine-query.

Here are some ideas:

• The add function could always rename the variables and add a postfix, e.g. id -> id_0 to avoid collision
• Accept "global variables" in the combineQuery function and use them in all queries

I agree.
In my case i want to do multiple mutations on a cart which uses the cart_id variable which is always the same.

maybe we could add the ability to configure how it can resolve conflicts:

{
	allow_duplicates: ["cart_id"],
    suffix_duplicates: true
}

This way by default it would still throw the error.
If you allow a duplicate it may be nicer to you with variables you consider global, but still throw errors if you for example try and set both the billing and shipping address of someone using $address which would certainly not be intended behavior
And if you set suffix duplicates to true it will stay quiet and simply add an incrementing counter to these variables

from graphql-combine-query.