Git Product home page Git Product logo

Comments (13)

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024 3

@regiszanandrea, @boraguler library should support v4 endpoints now! Please test it 😸. Note that Champion Mastery endpoint is not working correctly yet (Serivce unavailable).

Also, the tests should be kind of working again. But definitely are not complete. So any additions are welcome.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024 1

Hey guys! Champion Mastery v4 and Tournament Stub v4 are up and running on a58847c 😼.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024 1

All v4 endpoints should be working on v3.0.0-alpha. Static data through RiotAPI still not implemented.

from riot-api.

boraguler avatar boraguler commented on September 24, 2024

I'm waiting for it too, can help you with it Daniel if needed.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

Hi guys,

there will be only minor adjustments to match v4 endpoint call changes. Thought there would be things I'd be grateful to get helped with -- I'll let you know soon 😆.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

So... I know that noone likes to write tests (#26) - BUT it needs to be done. And if you could help, that would be awesome!

There are also some things to be done to bridge StaticData calls from RiotAPI to DataDragonAPI (#25). But these are not that important.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

In the end, I wll manage to fix the tests by myself.

#25 should be priority now.

from riot-api.

regiszanandrea avatar regiszanandrea commented on September 24, 2024

@dolejska-daniel Working as Designed.

Thank you so much ❤️

from riot-api.

regiszanandrea avatar regiszanandrea commented on September 24, 2024

Hey @dolejska-daniel, I'll create a new issue for Tournament V4 Support, it's ok?

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

@regiszanandrea sure is! Didn't hear anything about Tournament v4 😮

from riot-api.

regiszanandrea avatar regiszanandrea commented on September 24, 2024

@dolejska-daniel I think the only thing that will change is in the tournament code creation, passing the encrypted summonerId

from riot-api.

regiszanandrea avatar regiszanandrea commented on September 24, 2024

@dolejska-daniel Tournament v4 is available :)

from riot-api.

regiszanandrea avatar regiszanandrea commented on September 24, 2024

@dolejska-daniel Love you ❤️

from riot-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.