Git Product home page Git Product logo

Comments (17)

regiszanandrea avatar regiszanandrea commented on September 24, 2024 1

Yeah, if you bring this library up-to date.

This is the official announcement: https://discussion.developer.riotgames.com/articles/6579/player-universally-unique-identifiers-and-a-new-se.html

I could help in developing something, because I'm using this library every day in a project. So if you need something you can email me at [email protected]

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024 1

I will do my best and I'll try to update it but I cannot tell you when I'll have enough time for it right now.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024 1

Hey guys, I am quite pleased to tell you, that StaticData calls are once more available through RiotAPI!

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024 1

@boraguler @TheKeymaster @regiszanandrea,
I'll close this issue since it is solved by new v3.0.0-rc.1 release. Please make sure to check out important changes in v3 so you don't have hard time updating 😼.

Any feedback is well appreciated! 😺

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

Hello and thank you for using this library 😃 I hope it works well for you.

I will try to implement workaround for StaticData deprecation for both DD & RiotAPI ASAP. I guess I will manage this week. We will see 😆... I will let you know when I do anyways. 😸

from riot-api.

boraguler avatar boraguler commented on September 24, 2024

Thank you very much.

By the way, I'm using a shared hosting. I had to add new doctrine/inflector version in composer manually, since it was giving errors when I uploaded to live. Just a reminder. /cheers

Edit: to be more specific, on similar lines such as "public function setSetting( string $name, $value ): self" and so on.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

Hey @boraguler,

what exactly does not work on DD API for you? I think that DD API went without changes during StaticData deprecation.. 🤔

from riot-api.

boraguler avatar boraguler commented on September 24, 2024

for ex. when i try the same with your example on here

or simply $api->getStaticChampion(61, null, null, 'all');

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

Okay -- that is actually not problem of DataDragon API itself, that is a problem of RiotAPI (due to StaticData endpoint deprecation).

from riot-api.

TheKeymaster avatar TheKeymaster commented on September 24, 2024

@dolejska-daniel is the static Data Dragon already included in the most recent version? If yes could you tell me the method name to get all Champions from the Data Dragon?

Thanks!

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

@TheKeymaster It's not there yet, I'll try to look into it today. I'm currently quite busy with my Bachelor's thesis and other school projects 😩. I'm sorry it's taking this long.

from riot-api.

TheKeymaster avatar TheKeymaster commented on September 24, 2024

@dolejska-daniel thanks for your quick response and fix!
Just for your information; I can't get the latest version from packagist. I need to use composer require dev-master to get the latest version.
Could you create a new version on packagist as well? That would be great!

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

@TheKeymaster The static-data are only available through DataDragon not RiotAPI itself. This has to be done explicitly so static-data objects can be created by RiotAPI and I did not have time for that just yet.

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

I've created release v2.0.1 anyways 😆. Just for you 😎.

from riot-api.

TheKeymaster avatar TheKeymaster commented on September 24, 2024

Thank you!!

from riot-api.

regiszanandrea avatar regiszanandrea commented on September 24, 2024

Hey @dolejska-daniel ,

There will be a new version of this library for Riot API v4?

Thanks

from riot-api.

dolejska-daniel avatar dolejska-daniel commented on September 24, 2024

Hi @regiszanandrea,

I haven't looked into that just yet - so I do not know the number of differences between these versions. What do you mean by "will there be a new version"? As if I bring this library up-to date? If this is the question then probably yes.

...thought to get some help would be awesome, since I am working on my Bachelor's Thesis 😸.

from riot-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.