Git Product home page Git Product logo

Comments (4)

EvgenyOrekhov avatar EvgenyOrekhov commented on May 16, 2024 2

or at least equal padding should be added to the right for symmetry.

Switcher should not mess with the paddings at all. Theme's paddings should be respected and preserved.

from dropin-minimal-css.

dohliam avatar dohliam commented on May 16, 2024

This is a bit tricky -- the padding is there because quite a few of the themes have zero padding by default, making the body text flush with the left margin (for example, Cardinal and Caramel). For most of the other themes, the body text is either centred or otherwise unaffected by the small amount of padding.

Having said that, turning off the padding (using the Firefox dev console) does not seem to have any effect on Holiday CSS at a number of different screen sizes I tried, so perhaps you were able to fix this already?

from dropin-minimal-css.

EvgenyOrekhov avatar EvgenyOrekhov commented on May 16, 2024

For some reason turning it off via the dev console doesn't remove the padding. Tried both in Firefox and in Chrome.

If a theme has zero padding, then that's how the author intended it to look. I think the switcher should not try to "fix" paddings and whatnot.

from dropin-minimal-css.

brennanbrown avatar brennanbrown commented on May 16, 2024

@EvgenyOrekhov, it seems as though the reason you can't remove the padding is because it's being created by the js file on line 53:

  document.body.style.paddingLeft = "24px";

I agree that it should be removed, or at least equal padding should be added to the right for symmetry.

from dropin-minimal-css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.