Git Product home page Git Product logo

Comments (5)

Anthodpnt avatar Anthodpnt commented on August 10, 2024

Hi @jesperlandberg,

Yes you'll have to do your conditional stuffs in your transitions.
The Highway.Core is called once to setup Highway with the renderers and transitions.

This means that once it's called it's not aware of any DOM changes.
If you want to watch DOM changes and change the transition you'll have to work within the transitions.

This way when the transition is called, if the body has the classname is-open you can change it.
I'm curious, what kind of transition would you like to do ?

Because if it's an animation when a menu or something is opened this shouldn't be part of the transitions of Highway but more a transition in a file like header.js for example that would be called when the menu button is triggered... Assuming this is the kind of animation you want to achieve.

So in conclusion, you can't do this kind of conditional statement when calling Highway.Core and I don't think this is a feature coming in next version since I don't think it's an intended behaviour for this kind of library.

Best regards,
Anthodpnt

from highway.

jesperlandberg avatar jesperlandberg commented on August 10, 2024

Hi @Anthodpnt

I understand:) no problem, will do my check in the transition.js file!

Well basically, I have a mask element that I animate on transition, but when the menu is open during a transition, I will use the menu element as the mask, for the out part of the transition. No big deal and is easily made with conditionals inside the transition file. I attached a video clip if ur interested in seeing what I mean. Another option is just giving the default mask transition a delay and triggering my close menu method on NAVIGATE_OUT, so that the mask animation starts after the menu is closed... but that makes the whole switching pages to long=)

transition.zip

Loving the library so far btw! Good job:)

from highway.

Anthodpnt avatar Anthodpnt commented on August 10, 2024

Really nice work @jesperlandberg !
I would like to share this site when it will be live to show what is possible with Highway if you agree :).

from highway.

jesperlandberg avatar jesperlandberg commented on August 10, 2024

@Anthodpnt of course:) Will send over a link when live!:)

from highway.

Anthodpnt avatar Anthodpnt commented on August 10, 2024

@jesperlandberg Thanks ! Closing the issue.

from highway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.