Segmentation fault while making monitor with References and Quantifiers about reelay HOT 3 CLOSED

The parser needs -pthread option when linking on some platforms including Ubuntu.

Otherwise unittests are working for me. Could you run them with make test and report the outcome in any case?

from reelay.

I run the unittests and they works fine. So I got through them and looked at the one about the quantifiers operators and it seems a data_manager need to be set in the monitor's options to be able to parse the formula. I don't think it's told in the documentation, but I might have missed it... ^^'

The code of my first message can be fixed by adding :

  auto manager = std::make_shared<reelay::binding_manager>();
  auto options = reelay::dense_timed<time_t>::monitor<
      input_type, output_type>::options().with_data_manager(manager);

I haven't check if the generated monitor run fine yet. But, I would advise to check in the methods make_monitor of monitor.hpp if there is a data_manager set in opt when references are detected. If not, then print an error message advising to set it with the method with_data_manager(). This might help other people that forgot to set it to understand what is happening.

To solve it in ryjson1, a simple (naive?) way might simply be to always set a data_manager in the option of the monitor. However, I guess that it might have drawback on the performances when it's not needed. If so, maybe add a flag option to trigger it when needed or detect in the formula if a data_manager is needed with a first parsing step.

Sorry to have bother you with this, and thanks for your quick answer :-)

from reelay.

After further tests, the monitor seems to work correctly. I noticed that the method update of monitor using a quantifier operator return null instead of [ ] when the truth value remain the same. It should maybe be unified to avoid unexpected errors.

from reelay.