Git Product home page Git Product logo

Comments (6)

avalanche123 avatar avalanche123 commented on August 18, 2024

it should not be protected and you should not extend that class, you can set all the attributes in the constructor and you shouldn't access them from inside the class anymore.
What is your use case?

from mongodb.

jwhitcraft avatar jwhitcraft commented on August 18, 2024

I'm saying look at this class that jwage crated here: https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/Configuration.php where he does extend it and it causes parse notices in IDE's and such..

from mongodb.

avalanche123 avatar avalanche123 commented on August 18, 2024

good point, Jon, will you update the visibility then?

from mongodb.

jwhitcraft avatar jwhitcraft commented on August 18, 2024

Yes I will issue a pull request later today..

from mongodb.

avalanche123 avatar avalanche123 commented on August 18, 2024

Thank you!

from mongodb.

avalanche123 avatar avalanche123 commented on August 18, 2024

applied your pull, thanks!

from mongodb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.