Make this action compatible with aws-actions/configure-aws-credentials about login-action HOT 4 CLOSED

@dbuades This action already handles AWS Elastic Container Registry (ECR):

      - name: Login to Amazon ECR
        uses: docker/login-action@v1
        with:
          registry: ${{ secrets.ECR_REGISTRY }}
          username: ${{ secrets.ACCESS_KEY_ID }}
          password: ${{ secrets.SECRET_ACCESS_KEY }}

     - name: Build and push
        id: docker_build
        uses: docker/build-push-action@v2
        with:
          ...

If role-* are required on your side, then yes maybe we should be compatible with aws-actions/configure-aws-credentials.

from login-action.

@dbuades This action already handles AWS Elastic Container Registry (ECR):

      - name: Login to Amazon ECR
        uses: docker/login-action@v1
        with:
          registry: ${{ secrets.ECR_REGISTRY }}
          username: ${{ secrets.ACCESS_KEY_ID }}
          password: ${{ secrets.SECRET_ACCESS_KEY }}

     - name: Build and push
        id: docker_build
        uses: docker/build-push-action@v2
        with:
          ...

If role-* are required on your side, then yes maybe we should be compatible with aws-actions/configure-aws-credentials.

Yes, that's what I meant, we need roles on our side and unfortunately this action doesn't support them.
I guess making this action compatible with aws-actions/configure-aws-credentials is the easiest way to go, so that's why I suggested it.
Thanks and sorry if I didn't explain myself clearly!

from login-action.

@dbuades

Yes, that's what I meant, we need roles on our side and unfortunately this action doesn't support them.

My bad I read it wrong. Something like this should work in the meantime:

      - name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v1
        with:
          aws-access-key-id: ${{ secrets.ACCESS_KEY_ID }}
          aws-secret-access-key: ${{ secrets.SECRET_ACCESS_KEY }}
          aws-region: ${{ secrets.DEFAULT_REGION }}
          role-to-assume: ${{ secrets.ROLE_ARN }}
          role-duration-seconds: 1200
          role-session-name: GithubActions

      - name: Login to Amazon ECR
        uses: docker/login-action@v1
        with:
          registry: ${{ secrets.ECR_REGISTRY }}
          username: ${{ secrets.ACCESS_KEY_ID }}
          password: ${{ secrets.SECRET_ACCESS_KEY }}

     - name: Build and push
        id: docker_build
        uses: docker/build-push-action@v2
        with:
          ...

Env vars exported by aws-actions/configure-aws-credentials will be used through the ecr get-login cmd

from login-action.

That was really really quick, thanks!

from login-action.