When login with AWS session token, username is redundant, but it is required by action from v1.5 about login-action HOT 3 CLOSED

@MartinSolie

Actually, username was already required since 1.4.0 because we're using --password-stdin which requires --username so I don't think it worked for <1.5.

My bad about this one, login against ECR is actually handled through AWS CLI. Will be fixed through #21.

from login-action.

@MartinSolie

docker/login-action <1.5: it worked fine to run the action without username

Actually, username was already required since 1.4.0 because we're using --password-stdin which requires --username so I don't think it worked for <1.5.

Theoretically, we don't need aws_access_key_id and aws_secret_access_key. We need only aws_session_token to login into ECR because it has all needed for AWS information.

Are you on a self hosted runner? Because I don't see how python -c 'from boto3 import Session; print(Session().get_credentials().get_frozen_credentials().token)' can return a token. But we could solved this through #20.

Can you give me your entire workflow? Do you have a link to your repo?

from login-action.

Yeah, python script just extracts aws_session_token from previously generated ~/.aws/credentials file.

Thanks you a lot for a fast response !)

from login-action.