Git Product home page Git Product logo

Comments (10)

crazy-max avatar crazy-max commented on May 24, 2024 1

@svasek Oh sorry I completely forgot that one. Will setup smth this week!

from login-action.

crazy-max avatar crazy-max commented on May 24, 2024

@svasek Is the uses: aws-actions/configure-aws-credentials@v1 step working?

from login-action.

svasek avatar svasek commented on May 24, 2024

@svasek Is the uses: aws-actions/configure-aws-credentials@v1 step working?

I'm not sure as I've added it because it didn't work.

from login-action.

crazy-max avatar crazy-max commented on May 24, 2024

I'm not sure as I've added it because it didn't work.

Doesn't look like it aws-actions/configure-aws-credentials#222

from login-action.

crazy-max avatar crazy-max commented on May 24, 2024

Looking at their docs it should be capitalize HTTP_PROXY, HTTPS_PROXY I think or maybe we need this kind of pkg: https://github.com/awslabs/aws-sdk-v3-js-proxy#readme. I will open a PR to check this out.

from login-action.

svasek avatar svasek commented on May 24, 2024
  • The workflow fails in step Login to AWS ECR
  • It doesn't work even when I set environment variables capitalised
  • It doesn't work even when I use directly docker/login-action w/o aws-actions/configure-aws-credentials

from login-action.

svasek avatar svasek commented on May 24, 2024

Unfortunately it doesn't even when I tried it run directly:

      - name: Login to AWS ECR
        if: github.event_name != 'pull_request'
        uses: docker/login-action@v1
        with:
          registry: ${{ env.ECR_REPO }}
          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        env:
          NO_PROXY: ${{ env.NO_PROXY }}
          HTTP_PROXY: ${{ env.PROXYURL }}
          HTTPS_PROXY: ${{ env.PROXYURL }}

Log output:

Run actions/docker-login-action@v1
::save-state name=isPost::true
##[debug]Save intra-action state isPost = true
::save-state name=registry::***.dkr.ecr.us-west-2.amazonaws.com
##[debug]Save intra-action state registry = ***.dkr.ecr.us-west-2.amazonaws.com
::save-state name=logout::true
##[debug]Save intra-action state logout = true
Retrieving registries data through AWS SDK...
##[debug]Requesting AWS ECR auth token for ***
AWS ECR detected with us-west-2 region
Error: connect ETIMEDOUT 54.240.253.186:443
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Login to AWS ECR

from login-action.

svasek avatar svasek commented on May 24, 2024

Hi @crazy-max, is there any update on this?

from login-action.

crazy-max avatar crazy-max commented on May 24, 2024

@svasek Can you try with:

      - name: Login to AWS ECR
        if: github.event_name != 'pull_request'
        uses: crazy-max/docker-login-action@aws-sdk-proxy
        with:
          registry: ${{ env.ECR_REPO }}
          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
        env:
          HTTP_PROXY: ${{ env.HTTP_PROXY_URL }}
          HTTPS_PROXY: ${{ env.HTTPS_PROXY_URL }}

from login-action.

svasek avatar svasek commented on May 24, 2024

Hi @crazy-max,
🎉 Congratulation! I can confirm it works like a charm in both scenarios.
So, It works even with the aws-actions/configure-aws-credentials.

It's also not necessary to set additional env for the step if proxy is set in the runner global environment.
Thank you very much. Good job!

► Run crazy-max/docker-login-action@aws-sdk-proxy
::save-state name=isPost::true
##[debug]Save intra-action state isPost = true
::save-state name=registry::***.dkr.ecr.us-west-2.amazonaws.com
##[debug]Save intra-action state registry = ***.dkr.ecr.us-west-2.amazonaws.com
::save-state name=logout::true
##[debug]Save intra-action state logout = true
Retrieving registries data through AWS SDK...
##[debug]Requesting AWS ECR auth token for ***
##[debug]Using http proxy http://proxy-us-aws.***.***:3128
##[debug]Using https proxy http://proxy-us-aws.***.***:3128
AWS ECR detected with us-west-2 region
(node:910) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Logging into https://***.dkr.ecr.us-west-2.amazonaws.com...
Login Succeeded!
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Login to AWS ECR

from login-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.