Behaviour After v.1.11.0 release our CI has started to fail when t

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Logging in to public.ecr.aws stopped working on v1.11.0 about login-action HOT 7 CLOSED

docker commented on May 24, 2024 6

Logging in to public.ecr.aws stopped working on v1.11.0

from login-action.

Comments (7)

AyrtonRicardo commented on May 24, 2024 4

@crazy-max it seems to be working with @test version.

Output:

Retrieving registries data through AWS SDK...
AWS ECR detected with eu-central-1 region
Logging into {VERY_NICE_HIDDEN_REGISTRY}...
Login Succeeded!

from login-action.

crazy-max commented on May 24, 2024 2

@TheMacies Thanks for your feedback. After investigation it could be linked to an issue with region. Will come back to you shortly.

from login-action.

AyrtonRicardo commented on May 24, 2024 1

@crazy-max sure thing I can test. Gimme few minutes.

Your example is similar to what I use here.

from login-action.

crazy-max commented on May 24, 2024 1

Should be fixed with docker/login-action@v1

from login-action.

AyrtonRicardo commented on May 24, 2024

Also facing this issue with private registry in eu-central-1 region.

Exactly version v1.10.0 works.

AWS ECR detected with eu-central-1 region
Error: The security token included in the request is invalid.

from login-action.

crazy-max commented on May 24, 2024

@AyrtonRicardo Can you post your workflow please?

from login-action.

crazy-max commented on May 24, 2024

@TheMacies @AyrtonRicardo Can you try with uses: docker/login-action@test?

Got it working on public.ecr.aws: https://github.com/docker/login-action/runs/4582352695?check_suite_focus=true#step:4:14

  ecr-public-aws-creds:
    runs-on: ${{ matrix.os }}
    strategy:
      fail-fast: false
      matrix:
        os:
          - ubuntu-latest
          - windows-latest
    steps:
      -
        name: Checkout
        uses: actions/checkout@v2
      -
        name: Configure AWS Credentials
        uses: aws-actions/configure-aws-credentials@v1
        with:
          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          aws-region: us-east-1
      -
        name: Login to ECR
        uses: docker/login-action@test
        with:
          registry: public.ecr.aws