Git Product home page Git Product logo

Comments (8)

duglin avatar duglin commented on August 26, 2024

See moby/moby#20865

from engine-api.

Random-Liu avatar Random-Liu commented on August 26, 2024

@duglin Yeah, I saw that one. :)

I think in moby/moby#20865, people were mainly talking about the Docker CLI. While this one is just talking about the engine-api, which is a little different:

  1. People may use engine-api to build anything, they may need to use Go 1.4 for some reason.
  2. This issue is easier to fix because it's only about engine-api, I don't think it will affect too many people.

from engine-api.

vdemeester avatar vdemeester commented on August 26, 2024

I do agree with @Random-Liu, maybe we should handle this in here too.
/cc @calavera @MHBauer

from engine-api.

Random-Liu avatar Random-Liu commented on August 26, 2024

Thanks, @vdemeester!

BTW, we are switching from go-dockerclient to this official engine-api, :). There is no such problem in go-dockerclient (See here)

from engine-api.

MHBauer avatar MHBauer commented on August 26, 2024

We have control of the default client, so we should be able to handle it. Is there a way uses of engine-api can work around this by providing a customized client? We should work out both ways, if possible.

from engine-api.

duglin avatar duglin commented on August 26, 2024

Explicitly setting the value to something meaningful and valid should be easy enough to do. A PR would be welcome....

from engine-api.

Random-Liu avatar Random-Liu commented on August 26, 2024

@duglin Thanks, I'll send a PR soon :)

from engine-api.

calavera avatar calavera commented on August 26, 2024

Fixed by #190.

from engine-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.