Git Product home page Git Product logo

Comments (4)

chungers avatar chungers commented on August 12, 2024

@wfarner @fermayo - Please comment.

from deploykit.

wfarner avatar wfarner commented on August 12, 2024

It will be useful here to clearly delineate between the responsibilities of libmachete and swarm. If the primary objective of libmachete is to bring a machine to a state where a Docker engine is running, we should consider this out of scope. If we consider that libmachete is a more general-purpose tool that supports execution of shell commands and the like, it is in scope.

One bit of context that might help guide: is docker swarm join executed via the engine remote API (i.e. is there an engine API call to join a swarm)?

from deploykit.

fermayo avatar fermayo commented on August 12, 2024

I have mixed feelings about this one. I understand the separation of concerns here and the willingness to have libmachete completely ignore swarm stuff, but the fact is that those nodes deployed through libmachete will always need to join or create a swarm. IMHO libmachete's objetive should be to create a new node with a docker engine on it that either is the first one in a swarm, or has to join a swarm. Either way I think having libmachete understand this would make the UX much better.

In any case, having it as a step in the template as proposed here is a good compromise for now, keeps it clean, should be simple to implement (as the user will be specifying the IP of the master on the template).

from deploykit.

wfarner avatar wfarner commented on August 12, 2024

Closing this as InfraKit has evolved quite a bit since the discussion began. Swarm-related behavior will now be delegated to a plugin, which currently does support join behavior.

from deploykit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.