Git Product home page Git Product logo

Comments (5)

chris-crone avatar chris-crone commented on June 20, 2024

Thanks for raising this @karolz-ms! I've added it to our backlog.

from cloud-integration-beta.

gtardif avatar gtardif commented on June 20, 2024

Thanks for the proposal. Actually we looked at Service provider login for our CI as well.
One issue I see at the moment for providing this to users is that login through this method, I get an access token (valid for 1h) but no refresh token. So unlike the classic login, where the token is refreshed automatically, here the user has a token valid for 1h, and then gets an error message saying he needs to login again.
Maybe I missed something when implementing this, we can investigate a bit more to defined what is the best solution to improve this, or if we are happy to provide this in the CLI knowing the token will expire and not automatically refresh in this case. (cc @nebuk89)

from cloud-integration-beta.

gtardif avatar gtardif commented on June 20, 2024

Discussing this a bit further with @nebuk89, we'll include this in the CLI with the limitation that Service Principal login will obtain only an access token and no refresh token, the user will need to manually re-login when the token expires. This should not be an issue for CI use cases.
the CLI will provide: docker login azure --client-id xxx --client-secret yyy --tenant-id zzz

from cloud-integration-beta.

karolz-ms avatar karolz-ms commented on June 20, 2024

Makes sense, thanks Guillaume! I found this doc, which suggests that client credentials flow can only produce an access token, and not a refresh token https://docs.microsoft.com/en-us/azure/active-directory/develop/security-tokens#how-each-flow-emits-tokens-and-codes

Like you said, this is sufficient for CI scenario

from cloud-integration-beta.

gtardif avatar gtardif commented on June 20, 2024

Available since v0.1.12, using docker login azure --client-id xx --client-secret yy --tenant-id zz

from cloud-integration-beta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.