Comments (5)
bad in the sense that there is no communication
@ahangarha Yeah we should have a discussion about it, the thing is I just wanted to give you enough time to take a look at my implementation to have a better idea about it.
I would prefer to go slow with one or two libraries and find issues
Of course, by "wanting to implement bidi support for other libraries" I meant one specific library that I'm interested to work on (comrak). Otherwise, I can't think of any other libraries (except marked).
from markdown-it-bidi.
@ahangarha CC
from markdown-it-bidi.
Thank you for your insightful investigation.
Since before also we had discussion regarding nested elements, I think we need to drop support for nested elements and only keep adding dir="auto"
only to the root level elements. This includes blockquote.
Supporting nested elements should be postponed.
from markdown-it-bidi.
@ahangarha So we will end up implementing it anyway 😅
At this point, there is no reason to postpone nested elements support, we are already 1 month late for our schedule and we still haven't made real progress yet. The solutions are available for both blockquotes and tables and it's all about making a decision.
I believe that we should take a step forward and start preparing to write an initial specification for bidi-markdown. An incomplete spec isn't something that I'm willing for. I'm kind of in a rush since I'm supposed to implement bidi support for other libraries.
I'm going to write a full implementation in a separate branch then I'll let you review it. If you're okay with it we can go ahead and adopt it.
from markdown-it-bidi.
It both sounds good and bad. Good in the sense that you have ideas for implementation and bad in the sense that there is no communication on it. But it is good to make progress.
I would prefer to go slow with one or two libraries and find issues. I believe we need to take some steps in improving standards. In this sense I think it is better to have limited projects involved so that any future breaking change would have lesser negative impacts.
I suggest to not speed up this fast. It might make our work more difficult in future.
from markdown-it-bidi.
Related Issues (18)
- Automate npm publish on each release
- Check compatibility with other plugins
- Make sure we have enough feedback
- Check minimum version of markdown-it
- Make documentation
- Make proposal for CommonMark bidi support HOT 2
- Decide what to do with blockquotes HOT 9
- Add markdown-it-plugin as keyword to package.json HOT 1
- List of mixed RTL/LTR markdown documents for test HOT 4
- Direction of block quotes is reversed HOT 4
- Add linter
- Add test HOT 1
- Fix dependecies HOT 1
- Handle JS version HOT 1
- Add support for code blocks HOT 1
- Make demo
- Make website
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from markdown-it-bidi.