Improve train_test_split about nolearn HOT 3 CLOSED

I am currently using this:

class NeuralNetFix(NeuralNet):
    def train_test_split(self, X, y, eval_size):
        assert eval_size is None
        X_train = X
        y_train = y
        X_valid = self.X_valid
        y_valid = self.y_valid
        if not self.regression and self.use_label_encoder:
            y_valid = self.enc_.transform(y_valid).astype(np.int32)
        return X_train, X_valid, y_train, y_valid

I then handle the train_test_split myself.

UPDATE: I no longer read X_valid and y_valid from self.

from nolearn.

@cancan101 To answer your first question: You'll notice that NeuralNet.train_test_split uses StratifiedKFold for classification tasks. That's different to what sklearn's train_test_split would give you.

But maybe the stratified split isn't all that important, and we can just use an overridable train_test_split (component) by default.

from nolearn.

I think we can merge this discussion with #42, and close this one. Also consider #45 when thinking about a better way to override the train_test_split method.

from nolearn.