Comments (7)
Hi @monajalal , the backend doens't need to do this as the JSON API specifies that it will receive a list, not a string. I believe @edward-edberg did manage to split a string into a list in the frontend, but he should be the person to ask here.
from openframing.
Hi Mona,
I'm not sure why we'd be sending a comma separated string to the backend. As we discussed in the meetings before, JSON supports a list type, and I don't see any reason not to use a JSON list. In fact, to use a comma separated string instead of a JSON list appears to me to be confusing to future developers on this codebase.
from openframing.
We have to think about the user in the first place and what would be easier for them to input. Do you have a suggestion for a different sketch and could you maybe draw it with pen on the paper so I can have a look at your idea? @davidatbu
from openframing.
Hi Mona, it's totally fine if the user enters the input as a comma separated list if you think that would be best. Personally, I think that's just fine for now.
But, when that information is sent to the backend as JSON, that string needs to be "broken up" into a JSON list(by using something like string1.split(',')
in javascript).
from openframing.
Hi Mona, to be more explicit, if the frontend sends the category_names
as a JSON list(which I think is the right thing to do) then this Github issue is unnecessary. Not sure why you labelled it "high-priority" just now ...
from openframing.
is it done, right @davidatbu or @edward-edberg ?
from openframing.
Closing as this is self-evidently done because we can train classifiers using the frontend.
from openframing.
Related Issues (20)
- Provide example datasets in the framing and LDA pages so the user could test the functionalities without having their own data HOT 2
- Add 'queued for training' to the training statuses HOT 2
- Embedd the video tutorial in the 'Tutorials' tab of our Webpage
- Echo back to the user the error messages that the backend responds with HOT 1
- LDA topic name assignment doesn't work HOT 3
- Create additional pretrained classifiers HOT 8
- What are the minimum system specs required for AWS EC2 instance? Then Downgrade to it. HOT 2
- Change http://www.openframing.org to https://www.openframing.org HOT 1
- Let the user get a link in the email when training a classifier is done, and then upload an unlabeled set HOT 12
- Let the emails sent for training a classifier or topic model include metrics HOT 1
- Adding the project tags, descriptions, and Website to the 'About' section in GitHub HOT 1
- Add a one liner in HTML to explain to the user that they need two columns in their data namely Example, Label
- Provide instruction for the user in a line and let them know they should have only one column in their data
- Show a message to the user on the landing page of openframing.org when the system is down or under reconstruction
- Cannot input "/" in the label HOT 1
- When sharing the openframing.org in a social media (e.g. Facebook), the thumbnail is not good HOT 3
- Don't use 'gun violence' for 'other' policy issue when we ask the user to use 'our dataset' HOT 5
- Add an example to visualize framing in news HOT 6
- Document error messages in the backend API
- support for multiple languages for BERT and LDA HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openframing.