Git Product home page Git Product logo

Comments (7)

dnaaun avatar dnaaun commented on August 23, 2024 1

Hi @monajalal , the backend doens't need to do this as the JSON API specifies that it will receive a list, not a string. I believe @edward-edberg did manage to split a string into a list in the frontend, but he should be the person to ask here.

from openframing.

dnaaun avatar dnaaun commented on August 23, 2024

Hi Mona,

I'm not sure why we'd be sending a comma separated string to the backend. As we discussed in the meetings before, JSON supports a list type, and I don't see any reason not to use a JSON list. In fact, to use a comma separated string instead of a JSON list appears to me to be confusing to future developers on this codebase.

from openframing.

monajalal avatar monajalal commented on August 23, 2024

We have to think about the user in the first place and what would be easier for them to input. Do you have a suggestion for a different sketch and could you maybe draw it with pen on the paper so I can have a look at your idea? @davidatbu

from openframing.

dnaaun avatar dnaaun commented on August 23, 2024

Hi Mona, it's totally fine if the user enters the input as a comma separated list if you think that would be best. Personally, I think that's just fine for now.

But, when that information is sent to the backend as JSON, that string needs to be "broken up" into a JSON list(by using something like string1.split(',') in javascript).

from openframing.

dnaaun avatar dnaaun commented on August 23, 2024

Hi Mona, to be more explicit, if the frontend sends the category_names as a JSON list(which I think is the right thing to do) then this Github issue is unnecessary. Not sure why you labelled it "high-priority" just now ...

from openframing.

monajalal avatar monajalal commented on August 23, 2024

is it done, right @davidatbu or @edward-edberg ?

from openframing.

dnaaun avatar dnaaun commented on August 23, 2024

Closing as this is self-evidently done because we can train classifiers using the frontend.

from openframing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.