Git Product home page Git Product logo

Comments (8)

jcleung5549 avatar jcleung5549 commented on August 22, 2024

Added them manually. This eliminated the message regarding the Release annotation. Still not happy with the OwningEntity.

<Schema xmlns="http://docs.oasis-open.org/odata/ns/edm" Namespace="RedfishYangExtensions.v1_0_0">
  <Annotation Term="Redfish.OwningEntity" String="DMTF"/>
  <Annotation Term="Redfish.Release" String="1.0"/>

from yang-to-redfish-converter.

jcleung5549 avatar jcleung5549 commented on August 22, 2024

The OeningEntity annotation in RedfishExtensions_v1.xml has a different form.

  <Annotation Term="RedfishExtensions.v1_0_0.OwningEntity" String="DMTF"/>

from yang-to-redfish-converter.

jcleung5549 avatar jcleung5549 commented on August 22, 2024

Looks like the issue are in csdl-syntax-test.js

const NamespacesWithoutReleaseTerm = ['RedfishExtensions.v1_0_0', 'Validation.v1_0_0', 'RedfishError.v1_0_0', 'Schedule.v1_0_0', 'Schedule.v1_1_0' ];

function schemaOwningEntityCheck(csdl) {
  let schemas = CSDL.search(csdl, 'Schema');
  for(let i = 0; i < schemas.length; i++) {
    let owningEntity = CSDL.search(schemas[i], 'Annotation', 'Redfish.OwningEntity');
    if(owningEntity.length === 0) {
      let owningEntity = CSDL.search(schemas[i], 'Annotation', 'RedfishExtensions.v1_0_0.OwningEntity');
      if(owningEntity.length === 0) {
        throw new Error('Namespace '+schemas[i]._Name+' lacks OwningEntity!');
      }
    }
  }
}

from yang-to-redfish-converter.

mraineri avatar mraineri commented on August 22, 2024

It's different in RedfishExtensions_v1.xml because of the lack of aliasing in that file. All other files pull in "RedfishExtensions.v1_0_0" and alias it as "Redfish", but local aliasing does not seem possible.

from yang-to-redfish-converter.

jcleung5549 avatar jcleung5549 commented on August 22, 2024

Thanks for the guidance. I just have one error regarding OwningEntity.

1) CSDL Tests
       metadata/RedfishYangExtensions_v1.xml
         All Annotation Terms are valid:
     Error: Unable to locate annotation term "Redfish.OwningEntity"
      at checkAnnotationTerms (node_modules/redfishrepotest/csdl-syntax-test.js:651:13)
      at Context.<anonymous> (node_modules/redfishrepotest/csdl-syntax-test.js:152:51)
      at processImmediate (internal/timers.js:461:21)

But, the annotation is there

    <Schema xmlns="http://docs.oasis-open.org/odata/ns/edm" Namespace="RedfishYangExtensions.v1_0_0">
      <Annotation Term="Redfish.OwningEntity" String="DMTF"/>
      <Annotation Term="Redfish.Release" String="1.0"/>

from yang-to-redfish-converter.

mraineri avatar mraineri commented on August 22, 2024

It might be because it's lacking the inclusion of the RedfishExtensions file; try adding:

  <edmx:Reference Uri="http://redfish.dmtf.org/schemas/v1/RedfishExtensions_v1.xml">
    <edmx:Include Namespace="RedfishExtensions.v1_0_0" Alias="Redfish"/>
  </edmx:Reference>

from yang-to-redfish-converter.

jcleung5549 avatar jcleung5549 commented on August 22, 2024

Bingo!

Thanks. Your guidance is better than my flailing.

from yang-to-redfish-converter.

jcleung5549 avatar jcleung5549 commented on August 22, 2024

Resolved

from yang-to-redfish-converter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.