Git Product home page Git Product logo

Comments (1)

billdodd avatar billdodd commented on June 27, 2024

It's trying to trigger a redirect (301) by changing a uri like /redfish/v1/bar/ to /redfish/v1/bar (by stripping off the last character) and doing a GET on that new uri. That is the type of situation that will often trigger a redirect. But there a couple of problems with the current code:

  • If the uri is something like /redfish/v1/bar, stripping off the last character results in /redfish/v1/ba, which will almost certainly not get the expected behavior.
  • There is no requirement in the Redfish spec or http specs that the example given (/redfish/v1/bar/ to /redfish/v1/bar) will result in a redirect.

I think the code should be updated to do the following:

  • If the uri ends in '/', remove it.
  • If the uri does not end in '/', append one.
  • Do not fail if the request returns a status other than 301.
  • Continue to confirm a Location header is returned IF a 301 status is returned (and fail if the Location header is absent)

from redfish-service-conformance-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.