Comments (4)
billdodd
commented on June 27, 2024
Can you elaborate on how this assertion is failing for you? (snippet of the log showing the message(s) generated would help)
The request header section quoted indicates that it is not required for the client to send the If-None-Match header. And then for the service behavior, states:
If this HTTP header is present, the service will only return the requested resource if the current ETag of that resource does not match the ETag sent in this header. If the ETag specified in this header matches the resource's current ETag, the status code returned from the GET will be 304.
Looking at the code in the assertion I don't immediately see a problem with the logic (though there may well be one). Just need a better understanding of how it is failing in order to diagnose.
from redfish-service-conformance-check.
PhillipWatts1012
commented on June 27, 2024
Have a meeting in the morning but then will revisit the assertion. Thanks.?
…________________________________
From: Bill Dodd <[email protected]>
Sent: Wednesday, January 3, 2018 4:34 PM
To: DMTF/Redfish-Service-Conformance-Check
Cc: Watts, John - Dell Team; Author
Subject: Re: [DMTF/Redfish-Service-Conformance-Check] Assertion 6.5.6.8 fails, appears to require if-none-match (#61)
Can you elaborate on how this assertion is failing for you? (snippet of the log showing the message(s) generated would help)
The request header section quoted indicates that it is not required for the client to send the If-None-Match header. And then for the service behavior, states:
If this HTTP header is present, the service will only return the requested resource if the current ETag of that resource does not match the ETag sent in this header. If the ETag specified in this header matches the resource's current ETag, the status code returned from the GET will be 304.
Looking at the code in the assertion I don't immediately see a problem with the logic (though there may well be one). Just need a better understanding of how it is failing in order to diagnose.
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#61 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACN_nlvRB9zY_NgnHuM8s5OeW9ZXlThKks5tHABkgaJpZM4RSJ1F>.
from redfish-service-conformance-check.
PhillipWatts1012
commented on June 27, 2024
Complicated assertion. I'll start with this and research further.
~ GET:/redfish/v1/AccountService/Accounts/rackmanager_oper failed : HTTP status 200:OK, Expected status 304:Not Modified
Assertion Description: b'\n304 Not Modified\nThe service has performed a conditional GET request where access is allowed, but the resource content has not changed. Conditional requests are initiated using the headers If-Modified-Since and/or If-None-Match (see HTTP 1.1, sections 14.25 and 14.26) to save network bandwidth if there is no change.\n'
<--- Assertion 6.5.6.8: FAIL
…________________________________
From: Bill Dodd <[email protected]>
Sent: Wednesday, January 3, 2018 4:34 PM
To: DMTF/Redfish-Service-Conformance-Check
Cc: Watts, John - Dell Team; Author
Subject: Re: [DMTF/Redfish-Service-Conformance-Check] Assertion 6.5.6.8 fails, appears to require if-none-match (#61)
Can you elaborate on how this assertion is failing for you? (snippet of the log showing the message(s) generated would help)
The request header section quoted indicates that it is not required for the client to send the If-None-Match header. And then for the service behavior, states:
If this HTTP header is present, the service will only return the requested resource if the current ETag of that resource does not match the ETag sent in this header. If the ETag specified in this header matches the resource's current ETag, the status code returned from the GET will be 304.
Looking at the code in the assertion I don't immediately see a problem with the logic (though there may well be one). Just need a better understanding of how it is failing in order to diagnose.
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#61 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACN_nlvRB9zY_NgnHuM8s5OeW9ZXlThKks5tHABkgaJpZM4RSJ1F>.
from redfish-service-conformance-check.
billdodd
commented on June 27, 2024
Thanks, Phillip.
I looked again at the spec and my statement above was incorrect. I said:
The request header section quoted indicates that it is not required for the client to send the If-None-Match header.
The "No" in the "Required" column, of course, means that the server is not required to understand and be able to process the header (in this case the If-None-Match header).
So, you were right, we should not fail the assertion if it returns a 200.
I'll fix that to log a WARN instead. And I also noticed that the assertion incorrectly mentions POST and tests for POST as an allowable operation. I'll clean that up as well.
from redfish-service-conformance-check.
Related Issues (20)
- Update schema zip file property to point to 2018.3 bundle
- Assertion 6.4.2.3 incorrectly fails HOT 1
- Assertion 6.5.3 incorrectly requires HEAD support HOT 3
- Redfish-Service-Conformance-Check throws an assertion: got an unexpected keyword argument 'row_offset'
- Redfish-Service-Conformance-Check throws an assertion: TypeError: argument of type 'NoneType' is not iterable HOT 7
- Persistent caching of resource URIs causes unexpected behavior
- Request body causes an error in DELETE function
- @odata.context should be optional
- Update schema zip file URL to point to new 2019.1 bundle
- Assertion numbers based on spec location no longer match HOT 3
- Remove duplicative tests HOT 1
- Bug in 6.5.6.5 HOT 1
- HTTPSConnection issue with Python 3.4.3
- Assertion 7.5.16 always fails with reason irrelevant to the SUT HOT 2
- KeyError when returned json_body misses Redfish.Required property
- HTTP "Server" response header not required
- Running assertions fail in 1.2.1
- Assertion 6.4.25 fails for resource with transient data that changes etags HOT 5
- Assertion: COMP139 Traceback HOT 2
- Fails with latest version of openpyxl HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redfish-service-conformance-check.