Comments (6)
I think some lint options are too strict. I'm modifying the lint check and turn off some unnecessary ones.
from minpy.
Here are the lint error categories:
- invalid-name
- missing-docstring
- empty-docstring
- unidiomatic-typecheck
- line-to-long
- trailing-whitespace
- trailing-newlines
- multiple-statements (on single line)
- bad-whitespace
- bad-continuation
- multiple-imports
- wrong-import-order
- wrong-import-position
- no-self-argument
- import-error
- undefined-variable
- no-member
- dangerous-default-value
- pointless-statement
- pointless-string-statement
- expression-not-assigned
- exec-used
- attribute-defined-outside-init
- protected-access
- arguments-differ
- abstract-method
- super-init-not-called
- unnecessary-semicolon
- bad-indentation
- deprecated-module
- fixme
- unused-import
- unused-variable
- unused-argument
- redefined-outer-name
- redefined-builtin
- undefined-loop-variable
- cell-var-from-loop
- bare-except
- broad-except
- logging-format-interpolation
- deprecated-method
I think most of them should be fixed. Here are some exceptions:
fixme
should be allowed.protected-member
andinvalid-name
could be disabled locally.
What do you guys think? @hotpxl @lryta @HrWangChengdu
from minpy.
I agree with your proposal @jermainewang
from minpy.
I agree @jermainewang . I suggest we start working in this rule and give feedbacks if other exceptions are found to be necessary later.
from minpy.
I agree. Mandatory checks may be less strict but we could still recommend more strict checks for developers.
from minpy.
Solved.
from minpy.
Related Issues (20)
- second grad error HOT 5
- Training/inference distinction and multiple-output support in minpy.core.Function HOT 1
- Inputting auxiliary states to MXNet symbol via minpy.core.Function HOT 3
- minpy.core.Function handling top-down gradients w.r.t. multiple outputs HOT 3
- Typo Error in the Autograd Section of MinPy Tutorial HOT 1
- Can I create a variable shared by forward and back propagation in customop('numpy')? HOT 1
- [Help]How can we resume from an already saved parameters ? HOT 1
- How to install minpy and opencv correctly ? HOT 3
- How to specify a function's gradient function defined by users just like 'Autograd' ? HOT 3
- MNIST Solver cannot check accuracy when y is onehot encoded HOT 1
- reverse indexing does not work
- Cannot find 'engine' branch for minpy package HOT 3
- numpy.linalg missing
- Try to convert numpy code ,failed,Help!!! HOT 1
- minpy doesn't support astype function!!!
- How to use np.where HOT 1
- minpy.numpy.array dose not support len()
- np.where has not the same usage as numpy
- cannot use minpy.numpy.newaxis?
- concatenate throw exception "Operator _copyto inferring shapes failed." when input array is empty
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minpy.