Git Product home page Git Product logo

Comments (6)

lixin4ever avatar lixin4ever commented on May 18, 2024 1

@leezu I am happy to contribute to this project. How to start? Is there any guidance or documentation online?

from gluon-nlp.

lixin4ever avatar lixin4ever commented on May 18, 2024

@sxjscience Have you solved this problem?

from gluon-nlp.

leezu avatar leezu commented on May 18, 2024

@lixin4ever you can usually pass the root='/some/path/ parameter to functions that download files (ie datasets/models). The change proposed by @sxjscience needs some (trivial) changes in the code, but no-one has done them yet. If you would like to contribute it, please let us know and we can provide guidance.

from gluon-nlp.

leezu avatar leezu commented on May 18, 2024

@sxjscience @szha I suggest this change should also be applied to mxnet gluon, not only the gluon nlp package. In particular instead of choosing a environment variable such as GLUONNLP_HOME we could introduce MXNET_HOME.

@lixin4ever Great! We have some how to contribute documentation available.

For this issue I guess you could add a helper function _get_path(*args) to utils.py which would check if MXNET_HOME is defined and respectively join the looked up MXNET_HOME or default ~/.mxnet with the *args specified, returning the composed path. Then the functions that specify os.path.join('~', '.mxnet', ...) and their documentation need to be changed to make use of _get_path. But feel free to take a different route. What do you think?

from gluon-nlp.

szha avatar szha commented on May 18, 2024

@leezu We can start using MXNET_HOME with this package first and propagate the change back to mxnet later on.

from gluon-nlp.

sxjscience avatar sxjscience commented on May 18, 2024

Thanks @lixin4ever for contributing. This has been solved by #106 .

from gluon-nlp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.