Comments (10)
Yeah I actually just added support for iPhone 5 but haven't committed.
Would just need to change to make the top and bottom bars extend all the
way across. I will do it once Internet is good here #sandy
from dlcimagepickercontroller.
Sweet!!! I you want me to give it a shot before committing, I'm happy to help test with my code base. I've been rather ham-stringed in the last two days as well (I'm in the Boston area but thankfully now have power and internet again).
Thanks,
Joe
from dlcimagepickercontroller.
Mind trying it out on the 5 now?
from dlcimagepickercontroller.
iPhone 5 generally looks good, but when the filters are displayed, I think there's some overlap in the reflection. iPad is much better, however the view only seems to support portrait as of now and the nav bar buttons need to be spread out evenly. Let me know if you want me to take a look at the code as well to help adjust accordingly and commit changes back.
Thanks,
Joe
from dlcimagepickercontroller.
@jschwendt could you post a screen shot from the 5 so I can see what you mean?
from dlcimagepickercontroller.
Here's a screenshot with the filters closed: http://postimage.org/image/o0y10ozdz/
Here's a screenshot with the filters shown: http://postimage.org/image/m2h49wxvb/
In the second picture, notice the transparent whitish line near the bottom of the preview image. I think it's just that the filter dock background is in the wrong vertical position.
from dlcimagepickercontroller.
@jschwendt yup. I see what I did. I just pushed a fix that should do it.
from dlcimagepickercontroller.
Way better! I think iPhone 5 is all set. Up for tackling iPad next? I'm going to give it a shot to enable AutoLayout and handle all of the layout with constraints to see if that tackles things better. Springs and Struts were not getting the job done.
from dlcimagepickercontroller.
I have AutoLayout working across 3.5" and 4" screen iPhones as well as iPads. I also started work enabling the whole UI to rotate, but that's proving to be a bit more difficult. How can I send you what I have thus far?
from dlcimagepickercontroller.
I'm closing this because I've added iPhone 5 support to the project and the image picker but don't care so much about the iPad version
from dlcimagepickercontroller.
Related Issues (20)
- gpuimage.h file not found HOT 1
- Having difficulties with using images
- wrong web link at CocoaPods HOT 2
- Video picker not implemented.
- ios7 crash HOT 2
- Pod DLCImagePickerController 0.0.1 contains old code (with deprecations) HOT 2
- "self.wantsFullScreenLayout" is deprecated in iOS7 HOT 1
- Base SDK 6.1 casues shifting on iPhone 5 + HOT 4
- GPUImage removes blurSize property HOT 1
- Making Instagram like tilt-shift effect blur view.
- blur effect error HOT 1
- ARC Semantic Issues + Install instructions? HOT 9
- I can compile DLCImagePicker project from my project, but can't compile the project itself HOT 14
- Usage example? HOT 1
- Filter Button Customisation HOT 2
- Adjust brightness using UISlider in Static Image.
- can not take a photo in iphone 4 with ios 7 HOT 4
- Memory Issue HOT 2
- croppedImage is gone
- No visible @interface for 'GPUImageOutput<GPUImageInput>' declares HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dlcimagepickercontroller.