Mismatched data about timezones.json HOT 13 CLOSED

@BehindTheMath fell free to make pull request

from timezones.json.

PST is "pacific standard time" but here it says "pakistan standard Time"

from timezones.json.

When isdst=true, abbr and offset follow.
In my use case, I only use Text and utc[0] = "America/Detroit".
I use the TZ database to do the rest.

from timezones.json.

pakistan standard Time should be PKT

from timezones.json.

I think it should have been abbr_dst and offset_dst.
But this is a breaking change.

from timezones.json.

@dmfilipenko How about if we would change the format to something like this:

interface TimezoneDetails {
  value: string;
  abbr: string;
  offset: number;
  text: string;
}
export interface Timezone extends TimezoneDetails {
  dst: TimezoneDetails | false | null;
  utc: string[];
}

Here's an example of what it would look like:

  {
    "value": "Eastern Standard Time",
    "abbr": "EST",
    "offset": -5,
    "text": "(UTC-05:00) Eastern Time (US & Canada)",
    "dst": {
      "value": "Eastern Daylight Time",
      "abbr": "EDT",
      "offset": -4,
      "text": "(UTC-04:00) Eastern Time (US & Canada)",
    },
    "utc": [
      "America/Detroit",
      "America/Havana",
      "America/Indiana/Petersburg",
      "America/Indiana/Vincennes",
      "America/Indiana/Winamac",
      "America/Iqaluit",
      "America/Kentucky/Monticello",
      "America/Louisville",
      "America/Montreal",
      "America/Nassau",
      "America/New_York",
      "America/Nipigon",
      "America/Pangnirtung",
      "America/Port-au-Prince",
      "America/Thunder_Bay",
      "America/Toronto",
      "EST5EDT",
    ],
  },
  {
    "value": "Venezuela Standard Time",
    "abbr": "VST",
    "offset": -4.5,
    "text": "(UTC-04:30) Caracas",
    "dst": false,
    "utc": [
      "America/Caracas",
    ],
  },

The value, abbr, offset, and text properties would be in the root object for standard time, and again as properties of the dst property if applicable.

This would be a breaking change, and would require a major version bump.

from timezones.json.

@BehindTheMath This is a huge change. Unfortunately, I don't have much time to do this

from timezones.json.

I might do it myself and submit a PR.

What do you think of such a schema?

from timezones.json.

@BehindTheMath from a first view it might be useful. But what if we wouldn't make a nested object and add another timezone

{
 	"value": "Eastern Daylight Time",
    "abbr": "EDT",
    "offset": -4,
    "dst": true,
    "text": "(UTC-04:00) Eastern Time (US & Canada)",
    ...
},
{
	"value": "Eastern Standard Time",
    "abbr": "EST",
    "offset": -5,
    "text": "(UTC-05:00) Eastern Time (US & Canada)",
	"dst": false,
	...
}

I prefer to left this structure a flat

from timezones.json.

@dmfilipenko My issue with that way is that there's no relationship between standard and daylight timezones. So if I have one, there's no easy way to get the other.

from timezones.json.

@BehindTheMath I was thinking about and seemed like it is reasonable. Lets try to do this

from timezones.json.

@BehindTheMath any progress on this? This is so close to what we need

from timezones.json.

I kind of gave up on it and started using Luxon instead.

from timezones.json.