Comments (10)
I fixed this problem locally by updating installer.py
with the following code change:
if cf_cfg['DistributionConfig']['ViewerCertificate']['IAMCertificateId'] == self.certificate_id:
return;
to
if 'IAMCertificateId' in cf_cfg['DistributionConfig']['ViewerCertificate'] and cf_cfg['DistributionConfig']['ViewerCertificate']['IAMCertificateId'] == self.certificate_id:
return;
from certbot-s3front.
Also confirming that this is still not in pip but @plancast's update works perfectly.
from certbot-s3front.
Not sure it is evident from the log, but certbot had created and uploaded the cert at this point. I was able to manually go into the CF dist and update the dist to use the uploaded cert and the cert is valid and works.
from certbot-s3front.
Same here. On the default configuration, the xml returned has the following section:
<ViewerCertificate>
<CloudFrontDefaultCertificate>true</CloudFrontDefaultCertificate>
<MinimumProtocolVersion>TLSv1</MinimumProtocolVersion>
<CertificateSource>cloudfront</CertificateSource>
</ViewerCertificate>
Where the script is looking for IAMCertificateId
.
As mentioned, the cert is properly stored in the IAM user's server certificates and can be installed manually. After the first one is setup, installing (and therefore I think renew as well) through the script works as expected.
from certbot-s3front.
Facing the same issue with a new CF distribution.
from certbot-s3front.
@plancast do you want to send a PR for that change? it is a bug that I didn't test the latest version with a new distro.
from certbot-s3front.
Had the same problem. @plancast's changes made it work.
The changes don't seem to have been propagated to the pip registry yet.
from certbot-s3front.
@dlapiduz Would bumping the version number up to 0.4.2 cause PyPI to update its sources? I'm facing the same issue where it fails with KeyError: 'IAMCertificateId' using the pip installed package which currently is built from the source as it was on Jul 23, 2018.
from certbot-s3front.
@dlapiduz First, thanks for the awesome plugin. But it does still not seem to exist in pip. Had to manually patch it to get it work.
from certbot-s3front.
Hi folks, I just bumped the version and pushed to PyPi. Apparently the old CI system is not working anymore so I had to set up a new one...
from certbot-s3front.
Related Issues (20)
- ot
- This worked like a dream! Thank you. =) HOT 1
- Issue installing with certbot 0.23.0 HOT 1
- NoCredentialsError HOT 3
- Max retries exceeded with url HOT 3
- Can generate initial certificate, but silently fails to renew HOT 6
- [0.4.0] SyntaxError with python 3.6.6 HOT 1
- Error in configuring distribution with certificate HOT 1
- Cannot run on raspbian stretch HOT 1
- Not Python3 compatible HOT 2
- AttributeError: module 'certbot.interfaces' has no attribute 'RenewDeployer' HOT 1
- Configure dns in aws route 53
- Unreliable with load balancers and API Gateways HOT 1
- issue with certificate generation HOT 1
- Support non Amazon hosts (region endpoints)
- Unable to upload/update renewed cert via s3front HOT 1
- Add support for certbot 2.x HOT 1
- Failing when trying to use the docker container
- certbot: error: unrecognized arguments: --certbot-s3front:auth-s3-bucket my-bucket HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from certbot-s3front.