Comments (8)
Much better idea:
We can integrate an auto-merge image button in the dlang-bot comment that links over to the dlang-bot site. Then we can just activate auto-merge, or do any necessary login&oauth stuff, then redirect back.
from dlang-bot.
Do we need user OAuth tokens to merge on their behalf?
Well as long as git commits aren't signed, we can create the git commit on their behalf exactly as they would do locally (merge ourselves with dlang-bot, set the correct merge author and then push it).
Though that's probably more risky and work than merging with dlang-bot.
If you want to do it via the "safe" GitHub API, then yes we would need an OAuth token.
Could we live w/o the merge author in git and just use the dlang-bot account?
Idk, but sometimes it's quite nice to see how signed off a commit. On the other hand GitHub also saves the entire pull request history (e.g. who has set the label), so we wouldn't loose this information, but have to trust that GitHub doesn't screw up the info (unlikely).
What buttons to use? I think labels were proposed b/c they're already only editable by maintainers.
I agree - that's the simplest :)
(though there's the gotcha that labels don't trigger notification, but dlang-bot could post a comment as "warning")
from dlang-bot.
(though there's the gotcha that labels don't trigger notification, but dlang-bot could post a comment as "warning")
Not using notifications myself. What's the problem w/ that? You'd expect to get notified if someone turns on auto-merge? Does changing a comment trigger a new notification?
I'm actually not a friend of all the many bot comments, makes PRs sometimes very hard to read.
Label changes flow with the PR comment timeline, so that would be good enough IMO.
from dlang-bot.
What's the problem w/ that? You'd expect to get notified if someone turns on auto-merge?
Yes that's the current behavior.
Does changing a comment trigger a new notification?
No. Only new ones.
Label changes flow with the PR comment timeline, so that would be good enough IMO.
Just wanted to point out the difference to the current behavior. I think if no one complains it's fine without. After all we trust the maintainers and the merge will trigger a notification for itself (and if someone complains adding the "do a new comment feature" should be easy).
from dlang-bot.
It's possible to fetch a merged commit created by github, they're available under refs/heads/ID/merge.
git fetch upstream pull/6189/merge
git push upstream FETCH_HEAD:$base_branch
But the message is just merge refA into refB
.
A problem w/ OAuth and labels it that they're lacking a connection. You don't notice a missing session in dlang-bot when adding a label on the PR page. Having to visit an extra site as w/ the auto-tester is a bit annoying OTOH.
from dlang-bot.
Okay it seems like we need this feature as auto-tester doesn't seem to like the required branches.
from dlang-bot.
A simple version based on special labels: https://github.com/MartinNowak/dlang-bot/pull/17
from dlang-bot.
Solved with #17 :)
from dlang-bot.
Related Issues (20)
- clear shutdown of CI servers before deleting them
- Smart WIP handling HOT 3
- Bot does not recognize the switch from a draft PR to a full PR
- Bugzilla description partially discarded HOT 2
- Testsuite doesn't run on Alpine Linux / Musl HOT 1
- Don't merge PRs where non-required status are failing HOT 3
- Continuous TLS error on Scaleway API HOT 6
- Deployed Heroku instance should have debug infos HOT 1
- Bot ignore Azure pipelines failures HOT 2
- Bot cannot post on issues with Vibe.d v0.8.6 HOT 1
- The bot wrongly closes bugzilla issues from events generated by dlang-community projects HOT 1
- Query state of GitHub issues HOT 2
- Detect weblinks as reference to bugtracker issue HOT 6
- Update last commit message when merging with links to the PR and its title HOT 1
- Heroku stack is deprecated HOT 1
- dlang-bot for dub didn't tag the latest release HOT 1
- Bot didn't catch second bugfix HOT 2
- Tweaking bot with draft might be possible HOT 1
- Spurious escape in bug description HOT 1
- BUG: The dlang-bot doesn't Resolve Issues whose PRs Target the table branch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dlang-bot.