CPool allocation ownership about plugin-sdk HOT 6 CLOSED

The content of the function does not match documented-by-comment behavior. Good catch, case of the wrong copy paste? ^^

Since it is a function, not sure exactly if it should and did check for allocated memory prior to its execution. I am seeing that pools pretty much allocate memory on construction by default.

If nobody else fixes it I will probably do a quick-one this evening in 15 hours.

from plugin-sdk.

Probably so, yes. I am sure this is wrong since I remember stock SA function well - must have been a failure on my end when commiting that.

from plugin-sdk.

I have just committed a patch for that function, how I imagine it should work. Do you agree with the change?

from plugin-sdk.

I'm not 100% sure if deletion at Init time is safe - are these fields ensured to be initialized at construction time? If so, it looks OK.

operator delete can be called on a null pointer btw.

from plugin-sdk.

Good point. We are being very hypothetic anyway because reimplementation is not the goal of plugin-sdk anyway, I think. :)

The latest commit should fit the bill.

from plugin-sdk.

Yep! Good stuff!

from plugin-sdk.