Comments (6)
The code there is just copied from getOptionValue, i havent gotten around to reworking it to decode suboptions.
from net-dhcp.
Alright. I can do that and submit a PR.
from net-dhcp.
I would be delighted to accept the PR
from net-dhcp.
Just FYI There are packet captures of option 82 in the t/data directory and tests that are already examining those captures. Both would be a great lace to tune your code. If you have more exotic captures of option 82 thy would be great to have added!
from net-dhcp.
It seems like RFC 3046 does not define what data types individual suboptions are required to take. Our use-case for it requires that suboption 1 (client id) is a string, but the pcap data files in the t/ directory have suboption 1 values that are clearly hex (leading null bytes).
Luckily, people can just use getSubOptionRaw()
to get the raw string version, and getSubOptionValue()
to get the hex value, but what about any other format? Do we just make people do the thing themselves?
from net-dhcp.
Youre seeing why its not implemented :)
Have a go at it as best you can, and in general I just see what wireshark does with the packet then take that as being correct.
from net-dhcp.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from net-dhcp.