Better events and exceptions about cloudbackupbundle HOT 12 OPEN

Looks great!

Just realized that we may need the filename of the backup in BackupEvent?

from cloudbackupbundle.

Hm, tell me more. Why should filename be in the BackupEvent?

from cloudbackupbundle.

When you got many projects you might want to know which backup has been completed

from cloudbackupbundle.

The UploadEvent is dispatched after a file it uploaded. It might be one or it might be 100 files on 4 clients.
We can not use filename in Backup event since we don't know how many files or if they still are named the same.
We could however use the output_file_prefix or a variant of that... But... tell me more. Where are you looking when you "want to know which backup has been completed". In a centralized logger? Don't you see from which project the logging messages comes from? I don't quite understand.

from cloudbackupbundle.

What BackupEvent could have as a property is how long it took the operation to finish.

from cloudbackupbundle.

Is that interesting for all events?

from cloudbackupbundle.

Only for those that actually may take some time.

from cloudbackupbundle.

@Nyholm Hmm as far as I know, we only upload one archive to many destinations, so we know what will be the filename of the backup, right?

from cloudbackupbundle.

The UploadEvent is dispatched from the ClientManger it will know of the filenames.

But do you think it is within the scope of the BackupEvent to know all the filenames that was uploaded?
Or, maybe it makes sense to have an array of filenames in the BackupEvent form a DX perspective. It is a lot easier that collect info from UploadEvent and then take action as soon as BackupEvent is dispatched.

from cloudbackupbundle.

Oh ok I get it.
So you suggest to add an event listener on both events to get the filename from the BackupEvent?

from cloudbackupbundle.

Yeah, That was my suggestion but I'm reconsidering it now. Because we might do things too complicated for the users.

from cloudbackupbundle.

so how would you get now the backup file name that is created?
I understand that there is only 1 event dispatched upon success and the event itself does not have any information.

if ($successful) { $this->eventDispatcher->dispatch(BackupEvent::BACKUP_COMPLETED, new BackupEvent()); }

The reason I need the file name is that I need to send an email to the admin to inform him that the backup file (XXX) has been created and uploaded to storage.

from cloudbackupbundle.