Source code issue about flower HOT 16 OPEN

Things changed, you need IAR version 10.30...

@MatthijsThijssen, I suggest you recover your original comment and add this as and EDIT: below.

I think we will resolve this eventually. Personally I wouldn't be happy with myself providing "just use older version of the tool" as a requirement or solution. Things do change, but in case of compilers usually for the better. I have IAR 10.40.1 installed, have compiled this repo successfully, but haven't had a time to test and debug it yet. It seems like also @nurikk cannot dedicate much time to this project, but eventually someone will find a fix for newer version and this issue could be properly closed. Maybe you can change the title for something more related, e.g. "Compiling using IAR version higher than 10.30".

Relates to #10.

Also the original manual linked by nurikk in #21's comment and by me in #10's comment in is currently 404 - Not found, se we need new instruction anyway.

from flower.

Nothing has been changed in zstack 3.0.2 since 2007... So sticking to old version or IAR is a good idea.

Here is download link
http://netstorage.iar.com/SuppDB/Protected/PRODUPD/013455/EW8051-10301-Autorun.exe

from flower.

Hi,
Trying to get hex compiled from source to move on to fixing clusters issue for DeCONZ integration.
But unfortunately output hex I am getting after compilation seems to be broken. The same device works fine when I use precompiled hex, but my own version result in solid LED after reflashing and blinking LED after the button press. No pairing (
There were some warnings when compiling, anyone has a clue what could be the issue?
Warning[Pe047]: incompatible redefinition of macro "INP" (declared at line 10 of "C:\ C:\Texas Instruments\Z-Stack 3.0.2\Components\osal\include\comdef.h 63 Texas Instruments\Z-Stack 3.0.2\Projects\zstack\HomeAutomation\Flower\zstack-lib\ utils.h")

Warning[Pe128]: loop is not reachable C:\Texas Instruments\Z-Stack 3.0.2\Components\hal\common\hal_assert.c 245

Warning[w6]: Type conflict for external/entry "GetBindingTableEntry", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindFind", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindFindExisting", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindIsClusterIDinList", in module APS against external/entry in module BindingTable; function types differ in parameter 1; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindRemoveClusterIdFromList", in module APS against external/entry in module BindingTable; function types differ in parameter 1; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindRemoveEntry", in module APS against external/entry in module BindingTable; function types differ in parameter 1; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "pbindAddEntry", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

from flower.

Hello, this warnings absolutely harmless. Kindly refer to this manual to setup your development environment https://zigdevwiki.github.io/Begin/IAR_install.html

from flower.

@nurikk is this page lately 404 only for me?

from flower.

My bad https://zigdevwiki.github.io/Begin/IAR_install/

from flower.

Hello, this warnings absolutely harmless. Kindly refer to this manual to setup your development environment https://zigdevwiki.github.io/Begin/IAR_install.html

OK, that means it should work but it doesn't, just the same solid LED after flashing to the device (or rebooting it) and blinking LED when pressing the button. I've compared precompiled hex files from this repo with file compiled by me and it is a lot different (it has the same size but contents have just a few similar raws, all in "red" when trying to diff it...
Reinstalled IAR environment 10.30 from scratch and also cloned repo once again with no avail.
Also tried to glance into Project options, seems like it has everything preconfigured as expected (some custom options for Compiler, Linker, etc...)
Any idea what could be my issue?

from flower.

Have you applied SDK patch? (Mentioned on wiki page)

Apply SDK patch
After installing the IAR, you should apply the patch to correctly compile the sources.

You can find the patch here

How-to install:

Save 0001-Fixes.patch to your Z-stack working directory (C:\Z-Stack 3.0.2)
Open console at Z-stack working directory
Run git apply 0001-Fixes.patch

from flower.

Have you applied SDK patch? (Mentioned on wiki page)

Apply SDK patch
After installing the IAR, you should apply the patch to correctly compile the sources.

You can find the patch here

How-to install:

Save 0001-Fixes.patch to your Z-stack working directory (C:\Z-Stack 3.0.2)
Open console at Z-stack working directory
Run git apply 0001-Fixes.patch

I did, even verified manually that it was actually made changes to the z-stack files ((

from flower.

Can you confirm that you’re using correct build profile(DIYRuZ flower)?

from flower.

Complete rebuild all log might help me

from flower.

Complete rebuild all log might help me

Hi @nurikk, really appreciate you help. I've uploaded a full build log here
https://github.com/TPertenava/flower/blob/master/firmwares/buildlog_Flower.log

from flower.

Complete rebuild all log might help me

Hi @nurikk, really appreciate you help. I've uploaded a full build log here
https://github.com/TPertenava/flower/blob/master/firmwares/buildlog_Flower.log

You're using incorrect workspace, you need to use DiYRuZ_Flower

from flower.

You're using incorrect workspace, you need to use DiYRuZ_Flower

Wow, it worked, thanks a bunch!!

from flower.

Error executing file

error: corrupt patch at line 46

from flower.

I have the same issue as TPertenava with several Warnings.

Warning[Pe047]: incompatible redefinition of macro "INP" (declared at line 10 of "D:\ti\Z-Stack 3.0.2\Projects\zstack\HomeAutomation\flower-2.1.0\zstack-lib\utils.h") D:\ti\Z-Stack 3.0.2\Components\osal\include\comdef.h 63

Warning[Pe128]: loop is not reachable D:\ti\Z-Stack 3.0.2\Components\hal\common\hal_assert.c 245

Warning[w6]: Type conflict for external/entry "GetBindingTableEntry", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindFind", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindFindExisting", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindIsClusterIDinList", in module APS against external/entry in module BindingTable; function types differ in parameter 1; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindRemoveClusterIdFromList", in module APS against external/entry in module BindingTable; function types differ in parameter 1; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "bindRemoveEntry", in module APS against external/entry in module BindingTable; function types differ in parameter 1; class/struct/union types have different sizes

Warning[w6]: Type conflict for external/entry "pbindAddEntry", in module APS against external/entry in module BindingTable; function return types are different; class/struct/union types have different sizes

The Fix is applied an modifictions in the two Files are Done. I use the right Workspace.

from flower.