Git Product home page Git Product logo

Comments (9)

mkoistinen avatar mkoistinen commented on July 24, 2024

Sounds like you're proposing the right way forward to me.

from aldryn-forms.

yakky avatar yakky commented on July 24, 2024

I agree on the general idea.
We should use plain TextField with externally encoded json, though, to be compatible with every database instead of relying on specific field type (if I understand correctly the jsonfield / array field mentions)

from aldryn-forms.

czpython avatar czpython commented on July 24, 2024

@yakky yes is why I think we should use https://github.com/bradjasper/django-jsonfield which uses a textfield for representation and takes care of serialization and such

from aldryn-forms.

yakky avatar yakky commented on July 24, 2024

@czpython "django-jsonfield is looking for maintainers" :(

from aldryn-forms.

czpython avatar czpython commented on July 24, 2024

So I've tried to find a way to cleanup the old form submissions to match proper fields in the form,
unfortunately because form submissions have no direct relationships to the form except for a name
and because of the big : problem, it's just impossible to accurately determine which entries are fields and which are not.

To properly fix this going forward, I've decided to create another model for form data that will have the new form structure as json (without using json field). The structure will include the field type, field label and field value.

The old structure will remain in the admin/db to be slowly deprecated and allow time to export this data.

Migrating the old data format to the new is not possible because things like field type are impossible to know from the old format.

from aldryn-forms.

yakky avatar yakky commented on July 24, 2024

@czpython looks perfectly reasonable

from aldryn-forms.

fmarco avatar fmarco commented on July 24, 2024

+1

from aldryn-forms.

trawick avatar trawick commented on July 24, 2024

Close this ticket?

from aldryn-forms.

czpython avatar czpython commented on July 24, 2024

Yes, thanks!.
Fixed by b50e039

from aldryn-forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.