Comments (9)
Sounds like you're proposing the right way forward to me.
from aldryn-forms.
I agree on the general idea.
We should use plain TextField with externally encoded json, though, to be compatible with every database instead of relying on specific field type (if I understand correctly the jsonfield / array field mentions)
from aldryn-forms.
@yakky yes is why I think we should use https://github.com/bradjasper/django-jsonfield which uses a textfield for representation and takes care of serialization and such
from aldryn-forms.
@czpython "django-jsonfield is looking for maintainers" :(
from aldryn-forms.
So I've tried to find a way to cleanup the old form submissions to match proper fields in the form,
unfortunately because form submissions have no direct relationships to the form except for a name
and because of the big :
problem, it's just impossible to accurately determine which entries are fields and which are not.
To properly fix this going forward, I've decided to create another model for form data that will have the new form structure as json (without using json field). The structure will include the field type, field label and field value.
The old structure will remain in the admin/db to be slowly deprecated and allow time to export this data.
Migrating the old data format to the new is not possible because things like field type are impossible to know from the old format.
from aldryn-forms.
@czpython looks perfectly reasonable
from aldryn-forms.
+1
from aldryn-forms.
Close this ticket?
from aldryn-forms.
Yes, thanks!.
Fixed by b50e039
from aldryn-forms.
Related Issues (20)
- Advanced form allows to create a user, but can't select the created user because it's created without the superuser flag
- Field instances require the `name` field to be unique, but don't enforce it which leads to errors HOT 1
- In advanced form available email variables are displayed with raw html tags HOT 1
- Make the aldryn-forms file field to send the direct link to file in the email
- aldryn-forms always redirects on the default language after submit
- ImportError: cannot import name 'python_2_unicode_compatible'
- FormSubmission is missing "WHO submitted the form" (ready to make a PR)
- Form Validation (other than simple required and length)
- Suggestion - Select field (More fields to edit)
- xlrd / xlwt requirements not specified
- Edit output form
- EmailBackend connection is not being closed
- Select field not showing the options HOT 1
- Upgrading to version 6.2.1 causes "KeyError FormPlugin" HOT 1
- Empty form submission saved if redirect is enabled HOT 1
- When using simple captcha invalid requests create empty form
- Hedden Field default value
- Error when exporting form entries
- When submit the form it ignores captcha field
- Error when submitting the form OSError at / HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aldryn-forms.