Git Product home page Git Product logo

Comments (4)

kyranet avatar kyranet commented on May 31, 2024 1

I'll suggest you something, cd /node_modules/discord-rpc && npm i discordjs/discord.js#your-desired-commit-hash.

Problem solved, and please don't open the same issue multiple times.

from rpc.

kyranet avatar kyranet commented on May 31, 2024 1

To be honest, what I do in some repositories is make discord.js a peer dependency, so people install their desired version/commit hash, although the support becomes more tricky because it's very hard to enforce support in a library that is quickly changing.

Nonetheless, when discord-rpc becomes stable, it'll most likely use a stable version of discord.js, being either v12.0.0 (whenever it releases as stable) or locked to a commit. This library is currently beta, so you shouldn't expect full stability.

from rpc.

james58899 avatar james58899 commented on May 31, 2024

But this just workaround, I think this issue should be fix

from rpc.

devsnek avatar devsnek commented on May 31, 2024

I actually pin them to master because rpc will become stable with v12 and pinning to a hash will backtrack compat. I appreciate that you think I don't care but in actuality I'm just being pragmatic.

from rpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.