Comments (10)
didinele
commented on June 26, 2024
There's not enough relevant information here. What do you mean your function call isn't resumed?
from discord.js.
HRK44
commented on June 26, 2024
There's not enough relevant information here. What do you mean your function call isn't resumed?
I'll try to give more context:
Let's say my bot is in 5 guilds, and it's checking for some members/roles, here's some pseudo-code:
async checkUserRole() {
const guilds = getGuilds();
for (const g of guilds) {
const members = await g.getMembers();
//...check if member has a certain role
}
//logging here once it's done
console.log('finished parsing 5 guilds');
}
while (true) {
await checkUserRole();
sleep(30s);
}
So my code will keep running this (while true), and I correctly see the logs, with sometimes some heartbeats in between (which is normal):
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
...
Then sometimes, the shard gets disconnected, which I guess is fine, could be some network issues, then I see this:
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
[83307] 2024-03-13T19:50:47.423Z debug: [WS => Shard 0] The gateway closed with an unexpected code 1006, attempting to resume.
[83307] 2024-03-13T19:50:47.424Z debug: [WS => Shard 0] Destroying shard
Reason: none
Code: 1006
Recover: Resume
[83307] 2024-03-13T19:50:47.424Z debug: [WS => Shard 0] Connection status during destroy
Needs closing: false
Ready state: 3
[83307] 2024-03-13T19:50:47.931Z debug: [WS => Shard 0] Connecting to wss://gateway-us-east1-b.discord.gg?v=10&encoding=json
[83307] 2024-03-13T19:50:47.934Z debug: [WS => Shard 0] Waiting for event hello for 60000ms
[83307] 2024-03-13T19:50:48.112Z debug: [WS => Shard 0] Preparing first heartbeat of the connection with a jitter of 0.3208934412049065; waiting 13236ms
[83307] 2024-03-13T19:50:48.114Z debug: [WS => Shard 0] Resuming session
resume url: wss://gateway-us-east1-b.discord.gg
sequence: 182254
shard id: 0
[83307] 2024-03-13T19:50:49.999Z debug: [WS => Shard 0] Resumed and replayed 73 events
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
So it resumes the calls after reconnecting the shard.
The issue is that sometimes, it somehow gets stuck and I only see the heartbeats:
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
finished parsing 5 guilds (wait 30s)
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
[74589] 2024-03-13T19:39:21.068Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
//indefinitely until I kill/restart process...
from discord.js.
HRK44
commented on June 26, 2024
Just happened again:
[83307] 2024-03-13T20:36:23.971Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 79ms.
[83307] 2024-03-13T20:37:05.215Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 73ms.
[83307] 2024-03-13T20:37:46.470Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 77ms.
[83307] 2024-03-13T20:38:27.721Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 78ms.
[83307] 2024-03-13T20:39:08.968Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 74ms.
[83307] 2024-03-13T20:39:50.221Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 76ms.
[83307] 2024-03-13T20:40:31.472Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 73ms.
[83307] 2024-03-13T20:41:12.727Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 77ms.
[83307] 2024-03-13T20:41:53.983Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 81ms.
[83307] 2024-03-13T20:42:35.224Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 73ms.
[83307] 2024-03-13T20:43:16.493Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 91ms.
[83307] 2024-03-13T20:43:57.731Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 79ms.
[83307] 2024-03-13T20:44:38.981Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 78ms.
[83307] 2024-03-13T20:45:20.230Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 76ms.
[83307] 2024-03-13T20:46:01.480Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 76ms.
[83307] 2024-03-13T20:46:42.731Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 76ms.
[83307] 2024-03-13T20:47:23.984Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 78ms.
[83307] 2024-03-13T20:47:55.165Z debug: [WS => Shard 0] Destroying shard
Reason: Told to reconnect by Discord
Code: 4200
Recover: Resume
[83307] 2024-03-13T20:47:55.165Z debug: [WS => Shard 0] Connection status during destroy
Needs closing: true
Ready state: 1
[83307] 2024-03-13T20:47:55.748Z debug: [WS => Shard 0] Connecting to wss://gateway-us-east1-b.discord.gg?v=10&encoding=json
[83307] 2024-03-13T20:47:55.752Z debug: [WS => Shard 0] Waiting for event hello for 60000ms
[83307] 2024-03-13T20:47:55.971Z debug: [WS => Shard 0] Preparing first heartbeat of the connection with a jitter of 0.3551804231492781; waiting 14651ms
[83307] 2024-03-13T20:47:55.973Z debug: [WS => Shard 0] Resuming session
resume url: wss://gateway-us-east1-b.discord.gg
sequence: 237673
shard id: 0
[83307] 2024-03-13T20:47:56.185Z debug: [WS => Shard 0] Resumed and replayed 43 events
[83307] 2024-03-13T20:48:10.622Z debug: [WS => Shard 0] First heartbeat sent, starting to beat every 41250ms
[83307] 2024-03-13T20:48:10.700Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 78ms.
[83307] 2024-03-13T20:48:51.947Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 74ms.
[83307] 2024-03-13T20:49:33.198Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 75ms.
[83307] 2024-03-13T20:50:14.455Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 82ms.
[83307] 2024-03-13T20:50:55.702Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 79ms.
[83307] 2024-03-13T20:51:36.961Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 87ms.
[83307] 2024-03-13T20:52:18.203Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 77ms.
[83307] 2024-03-13T20:52:59.455Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 77ms.
[83307] 2024-03-13T20:53:40.707Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 80ms.
[83307] 2024-03-13T20:54:21.957Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 77ms.
[83307] 2024-03-13T20:55:03.213Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 83ms.
[83307] 2024-03-13T20:55:44.467Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 79ms.
[83307] 2024-03-13T20:56:25.722Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 83ms.
[83307] 2024-03-13T20:57:06.974Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 84ms.
[83307] 2024-03-13T20:57:48.213Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 71ms.
[83307] 2024-03-13T20:58:29.481Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 89ms.
[83307] 2024-03-13T20:59:10.716Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 73ms.
[83307] 2024-03-13T20:59:51.971Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 76ms.
[83307] 2024-03-13T21:00:33.227Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 83ms.
[83307] 2024-03-13T21:01:14.475Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 80ms.
[83307] 2024-03-13T21:01:55.717Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 72ms.
[83307] 2024-03-13T21:02:36.972Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 76ms.
[83307] 2024-03-13T21:03:18.228Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 81ms.
[83307] 2024-03-13T21:03:59.476Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 80ms.
[83307] 2024-03-13T21:04:40.727Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 78ms.
[83307] 2024-03-13T21:05:21.978Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 80ms.
[83307] 2024-03-13T21:06:03.230Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 81ms.
[83307] 2024-03-13T21:06:44.481Z debug: [WS => Shard 0] Heartbeat acknowledged, latency of 81ms.
My pod doesn't "crash" so it's hard to detect and restart it because it stays in this "zombie" mode, seems to be connected but doesn't run my function.
from discord.js.
monbrey
commented on June 26, 2024
Pseudocode is a little hard to call a minimum reproducible sample.
I assume getMembers() is going to correspond to guild.members.fetch(). This call gets all the members of the guild via the websocket - it sends a socket payload and then waits to receive sufficient GUILD_MEMBERS_CHUNK events back, until the cache is full and it's size equals the guild.memberCount.
If I had to make a guess based on the logs you've provided, Discord is kicking your shard off and telling it to resume it's session in the middle of waiting for these chunks - so they probably don't all return. It might hang waiting for the rest of those chunks.
On that though - I don't understand why you're doing this every 30 seconds - at least the fetching part. Once populated, GuildMemberUpdate events will keep the cache up to date.
from discord.js.
HRK44
commented on June 26, 2024
Pseudocode is a little hard to call a minimum reproducible sample.
I assume
getMembers()is going to correspond toguild.members.fetch(). This call gets all the members of the guild via the websocket - it sends a socket payload and then waits to receive sufficientGUILD_MEMBERS_CHUNKevents back, until the cache is full and it's size equals theguild.memberCount.If I had to make a guess based on the logs you've provided, Discord is kicking your shard off and telling it to resume it's session in the middle of waiting for these chunks - so they probably don't all return. It might hang waiting for the rest of those chunks.
On that though - I don't understand why you're doing this every 30 seconds - at least the fetching part. Once populated,
GuildMemberUpdateevents will keep the cache up to date.
Correct, here's the relevant part of my code:
const guild = await this.client.guilds.fetch(guildId);
await guild.members.fetch();
for (const data of dataarray) {
const discRole = await guild.roles.fetch(roleId);
//do custom logic, add/remove roles to users
....
I'm running it with a 30s pause because I make a lot of calls and don't want to spam too much (this is run by multiple pods on thousands of guilds)
from discord.js.
HRK44
commented on June 26, 2024
Based on your comments about the guild member chunk, if this resolves to false for some reason
could this get stuck there since it won't resolve/clear listeners? I've also noticed OOM after multiple days/hours (depending on how many guilds I pull, average 100) on my pods but that's less of an issue because I can restart them.from discord.js.
monbrey
commented on June 26, 2024
I think you've missed my point though - there is no reason to re-fetch entire guilds of members every 30 seconds. None at all.
After populating the guild member caches once and once only, events received by subscribing to the GuildMembers intent will ensure the cache is kept up to date.
You're welcome to run the rest of your functionality every 30 seconds, I'm not commenting on that.
from discord.js.
HRK44
commented on June 26, 2024
I understand I'll optimize the code to pull from cache instead of refetching everytime (I guess using membercount === member.length), but I think there's still some underlying issue with the websocket getting stuck in that heartbeat only mode.
from discord.js.
Qjuh
commented on June 26, 2024
Provide a reproducible sample that causes that to happen without your spam of unnecessary member fetches and we‘ll happily take a look.
from discord.js.
HRK44
commented on June 26, 2024
I identified the issue, it was from my own code logic (slow queries clogging the process). Closing the ticket, thanks for help!
from discord.js.
Related Issues (20)
- TypeError in GuildDeleteAction.handle when Destroying Voice Adapter HOT 13
- Bot send embed messages twice or even triple times after being not used for a while HOT 15
- Raw audio stream with AudioPlayer HOT 2
- [SlashCommandStringOptions] Be able to pass arguments to the constructor, or more builder options for SlashCommandStringOption HOT 2
- Publish a new release (dev build points to /ws that doesn't include a fix) HOT 3
- ClientPresenceStatusData Canary and PTB HOT 1
- ActionRowBuilder Constructor improperly merging provided components into new componentbuilders HOT 4
- Client is not receiving 'messageCreate' events HOT 1
- .toJSON() is 'unknown' HOT 1
- crashing after message deletion HOT 5
- Using channel.send on a channel where the bot has not the permission to post makes the whole program crash HOT 3
- Kicking the bot from its dev guild and inviting it again drops the slash commands HOT 6
- Automated Message nonce handling HOT 1
- Emit poll events on uncached messages
- `ws` throws `TypeError: Cannot use 'in' operator to search for 'code' in undefined` when with Deno HOT 6
- Wrong base URL for GIF stickers
- [Typing] `interaction.followUp()` should not have `ephemeral` in its options? HOT 6
- oops HOT 1
- Uncaught exception when adding member that is already part of the guild
- Readonly arrays in interfaces don't allow dynamically adding data
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from discord.js.