Git Product home page Git Product logo

Comments (14)

SpaceSaver avatar SpaceSaver commented on August 17, 2024

I could be wrong, but I believe that the issue here is not "Your files are too powerful," but instead Discord setting a size limit on the Webhook request size. This is why it splits into 25MB chunks instead of the usual Discord 8MB.

from web.

Cattn avatar Cattn commented on August 17, 2024

They recently raised the normal file size limit to 25MB so I'm not sure

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

They recently raised the normal file size limit to 25MB so I'm not sure

Well I goofed. Doing some experimentation, will get back to you if I don't forget.

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

I've discovered that the form body can't exceed 26214400 bytes in a normal server.

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

Another tidbit, you can add up to 10 attachments using follow up PATCH requests. The total size of the attachments in a message no longer need to be less than the limit (or they never did).

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

The only problem with this is that the PATCH requests need to include the attachment info from the message or the previous attachments get removed. This data brings us closer to the 25MiB request size limit.

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

Also, the "payload_json" form data section is not required and cuts into the 25 MiB.

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

The only problem with this is that the PATCH requests need to include the attachment info from the message or the previous attachments get removed. This data brings us closer to the 25MiB request size limit.

Actually, this is a lie. If you don't specify the attachment key in the json_payload, then just patching with the file, it appends instead of replacing. Also, you can patch without a filename getting you more bytes, but Discord will generate a random one and you would need to use attachment ids rather than message ids, which is less secure as the only thing that would need to be guessed would be the file name to steal ur stuff.

from web.

Philhubk98 avatar Philhubk98 commented on August 17, 2024

Take my advice and here is something you all need to know. Discord is going to limit sharing downloads next year! So whats the point with sharing downloads on Discord in the first place? better hope someone should take the source code out of Discord and make ourselves a real better alternative so we could stop using this overrated chatting app garbage but in the meantime while this is still the only chatting app thats easier to use for just communicating with friends but Im not sure about sending images or links to my dropbox anymore directly unless sending links from other sites don't affect Discord's very foolish download system?

from web.

Cattn avatar Cattn commented on August 17, 2024

Bro what lol they are just putting time limits on links, but if you download through the client it doesn't matter, so if you're using the feature as intended it's fine. It unfortunately may impact this project

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

Take my advice and here is something you all need to know. Discord is going to limit sharing downloads next year! So whats the point with sharing downloads on Discord in the first place? better hope someone should take the source code out of Discord and make ourselves a real better alternative so we could stop using this overrated chatting app garbage but in the meantime while this is still the only chatting app thats easier to use for just communicating with friends but Im not sure about sending images or links to my dropbox anymore directly unless sending links from other sites don't affect Discord's very foolish download system?

Link? Or are you referencing the inclusion of keys in the search parameters when you download from the client?

from web.

Cattn avatar Cattn commented on August 17, 2024

Take my advice and here is something you all need to know. Discord is going to limit sharing downloads next year! So whats the point with sharing downloads on Discord in the first place? better hope someone should take the source code out of Discord and make ourselves a real better alternative so we could stop using this overrated chatting app garbage but in the meantime while this is still the only chatting app thats easier to use for just communicating with friends but Im not sure about sending images or links to my dropbox anymore directly unless sending links from other sites don't affect Discord's very foolish download system?

Link? Or are you referencing the inclusion of keys in the search parameters when you download from the client?

Discord confirmed there will be a time limit on links (through search params I assume) to "prevent malaware distribution" but said that if you download through client it'll regenerate a link if it's been expired

https://www.theverge.com/2023/11/4/23946640/discord-file-links-will-expire-after-a-day-to-fight-malware

from web.

SpaceSaver avatar SpaceSaver commented on August 17, 2024

Take my advice and here is something you all need to know. Discord is going to limit sharing downloads next year! So whats the point with sharing downloads on Discord in the first place? better hope someone should take the source code out of Discord and make ourselves a real better alternative so we could stop using this overrated chatting app garbage but in the meantime while this is still the only chatting app thats easier to use for just communicating with friends but Im not sure about sending images or links to my dropbox anymore directly unless sending links from other sites don't affect Discord's very foolish download system?

Link? Or are you referencing the inclusion of keys in the search parameters when you download from the client?

Discord confirmed there will be a time limit on links (through search params I assume) to "prevent malaware distribution" but said that if you download through client it'll regenerate a link if it's been expired

https://www.theverge.com/2023/11/4/23946640/discord-file-links-will-expire-after-a-day-to-fight-malware

I don't believe that will break this as it requests new links via webhooks for every download. It would break their implementation of sharing though.

from web.

DisboxApp avatar DisboxApp commented on August 17, 2024

From prior discussion it seems Nitro still wouldn't increase the size limit for webhooks. Please reopen this if you find conflicting results.
As for the expiry tokens, that is handled.

from web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.