Git Product home page Git Product logo

Comments (3)

dingram avatar dingram commented on June 27, 2024

You're partially correct 😃

The function call you've given as an example has six arguments, whereas the README says that addNote() accepts up to five arguments. As you noted, the code itself doesn't actually accept a velocity argument for addNote().

I'll fix addNote() to accept a velocity argument as the docs say it should. What other argument were you expecting?

from jsmidgen.

jwktje avatar jwktje commented on June 27, 2024

Oops, yeah. I just typed out that example quickly. The second to last "32" should be ignored. I meant:
track.addNote(0, 50, 32, 0, 127);
Meaning:
Channel = 0
Note/Pitch = 50
Duration = 32 ticks
Time = 0
Velocity = 127

I would love to have the option for a velocity parameter. It seems that it just takes the default velocity set in the code. Is there a way to override this default without changing it the jsmidgen code?

Just wanna also mention, I'm loving this module you've written.
I'm including this module inside a Meteor app and I'm building a crazy insane art installation with it.
It honestly wouldn't be possible without your code, so thanks for making my hobby project a reality

from jsmidgen.

dingram avatar dingram commented on June 27, 2024

Thanks! I've fixed the code, and I'll be looking to release a new version to the NPM repository soon.

from jsmidgen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.