Handle Int::minValue() / -1 about dora HOT 5 CLOSED

@dinfuehr very cool, thanks! Just for my understanding, why "negate lhs"?

from dora.

Instead of dividing by -1, we should be able to negate the value: x / (-1) ==> -x.

from dora.

But the only value this applies is minValue ... so is the negate a short way to get -1?

from dora.

Maybe I am missing something, the logic looks like this:

if rhs == -1 {
  -lhs
} else {
  lhs / rhs
}

Instead of dividing by -1 we negate lhs. We do that for every lhs - not just minValue.

from dora.

Ah, now I understand ... thanks! I was first thinking of not, not neg, and got confused.

from dora.