Identify all public non-total functions and consider replacements about dora HOT 8 CLOSED

Incomplete list (feel free to add more):

• assert: This one is ok and doesn't need to be changed.
• {Long,Int,Byte}#div: Keep as-is.
• {Long,Int}#toChar: Migrate to Option?
• String#{fromBytesPartOrNull,fromStringPartOrNull}: Probably going away.
• Array#get: Keep as-is.
• Array#set: Keep as-is.

from dora.

Agreed, however I wouldn't change the return type for Array#get and Array#set to Option[T]. Additional methods that return an Option would be great though. At the moment those methods aren't declared throws either, it would just be too much boilerplate for array-heavy code without too much added value (most of the time folks would just write array(idx).unwrap() anyways. Following this logic even operations like a / b would have to return an option to handle div-by-0.

from dora.

I wouldn't change the return type for Array#get and Array#set to Option[T].

My hope would be that we would have a rich enough iterator/collections/streaming API one day, that we would look back on this and say "the alternatives are so good and popular, changing get/set to not throw would have minimal impact".

Also, having the array operations as Option would actually be more regular with other collection's lookup operations like Set#get or Map#get.

But I think we should keep it as-is, because there is still a long way to go before this can even be considered.

At the moment those methods aren't declared throws either, it would just be too much boilerplate for array-heavy code without too much added value [...]

Totally agree!

Following this logic even operations like a / b would have to return an option to handle div-by-0.

Agreed, I have been thinking about this some time ago and how it can be dealt with without introducing lots of boilerplate.

from dora.

Agreed, let's revisit this later.

from dora.

I think the remaining ones are easily identified due to the mandatory throws keyword, or are there any other exceptions like for arrays that you can think of?

from dora.

None that I remember right now.

from dora.

Great, thanks!

from dora.

I documented the existing (assumed public-facing) cases, I think this can be closed for now.

from dora.