Git Product home page Git Product logo

Comments (2)

sebcrozet avatar sebcrozet commented on August 15, 2024

I think the current support of multidispatch by rustc can give us just enough flexibility to fix this easily using something like this:

impl<N: Mul<N, N>> Vec2MulRhs<N, Vec2<N>> for N {
    #[inline]
    fn binop(left: &Vec2<N>, right: &N) -> Vec2<N> {
        Vec2::new(left.x * *right, left.y * *right)
    }
}

In fact I believe the only thing that prevents us from using multidispatch only instead of the double-dispatch trick are some corner-cases I encountered in ncollide that require better where clauses (though those corner cases might be related to the current issue and be fixed at the same time as this, I have to check).

from nalgebra.

milibopp avatar milibopp commented on August 15, 2024

The problem with that is just that you can't have multiple generic implementations, which would prevent Matrix * Vector and Matrix * Scalar to be implemented at the same time like this.

Maybe we could do something like this:

trait DDMul<C> {
    fn ddmul(&self) -> C;
}

impl<T: BaseFloat> DDMul<Vec2<T>> for (Vec2<T>, T) { /* ... */ }

impl<B, C> Mul<B, C> for Vec2
    where (Vec2, B): DDMul<C>
{
    fn mul(&self, other: &B) -> C { (*self, *other).ddmul() }
}

But this is only useful for the brief period between full where clauses and multidispatch.

from nalgebra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.