Revert to 2018 edition about rust-c-ares HOT 4 CLOSED

I prefer to do my bit to encourage the world to move forwards if I can!

I think we're some way off agreeing that alexcrichton/curl-rust#427 is a good idea; but if it is and if you're going to hide c-ares use behind a feature flag anyway then perhaps that's tolerable from curl-rust's point of view.

However I'm not totally against reverting to edition 2018 if that turns out to be the blocker on making things happen, let's leave this open while the discussion continues.

from rust-c-ares.

I could pin the dependency to the last version using edtion 2018, but I also need #41 patch.
I think it would be easier to revert edition for now.

from rust-c-ares.

Do we have a position from curl-rust as to whether they actually mind about this? alexcrichton/curl-rust#427 (comment) suggests

since this is behind the c-ares feature, maybe it isn't a major issue.

And of course time passes: we are now a full rustc release cycle on from the previous discussion, at some point "use 1.56 or later" really isn't a big ask.

I would prefer not to move backwards, but if the curl-rust folk can decide on what their policy is re supported rust versions then I'm probably open to going along with it to unblock this.

from rust-c-ares.

1.56.0 is six months old at this point, I'm gonna declare that it's totally reasonable to rely on edition 2018.

I'll publish a c-ares-sys with your build script enhancement #41.

It looks as though your curl-rust MR has lost momentum at this point: but if you do get it going again and the curl-rust folk really insist on supporting older rust versions, do come back to me. I'm not 100% against it; but it seems unlikely that we actually need to do it.

from rust-c-ares.