Comments (5)
shatoboar
commented on May 24, 2024
Hey, i would like to work on this :)
/assign
from digitalocean-cloud-controller-manager.
timoreimann
commented on May 24, 2024
Marko and I talked about this one on the Kubernetes Slack some time ago. This request does seem legitimate to me, especially given that we have had a similar need with our CSI driver and implemented it accordingly.
My suggestion would be to rename FAKE_REGION to REGION and let it take precedence if specified. The docs should be updated accordingly.
Our CCM is still at 0.x, so we shouldn't need to worry about backwards compatibility for a development-only feature.
from digitalocean-cloud-controller-manager.
timoreimann
commented on May 24, 2024
Thanks for taking over this one @shatoboar.
from digitalocean-cloud-controller-manager.
almereyda
commented on May 24, 2024
Now that #513 is merged, can this be closed?
from digitalocean-cloud-controller-manager.
timoreimann
commented on May 24, 2024
Release is yet to be done; but yeah, we can close the issue out already.
Thanks for reminding me @almereyda.
from digitalocean-cloud-controller-manager.
Related Issues (20)
- Help on Custom VPC with DO CCM HOT 2
- do-loadbalancer-protocol: 'http2' results in 'http2' --> 'http' HOT 4
- Extending Loadbalancer timeout duration HOT 1
- Misconfigured cloud-controller-manager.yml (HA deployment that uses daemonset) HOT 1
- Change release pipeline to promote dev manifests
- Protect load balancer from being deleted HOT 7
- udp loadbalancer failing to create HOT 8
- Controller manual mode HOT 17
- K8 annotations for load balancer name / id do not work as expected HOT 4
- Typos in README.md
- IPv6 address missing in nodes status HOT 9
- Prevent duplicate do-loadbalancer-name annotation from changing LB ownership
- do-loadbalancer should accept a certificate name as an alternative to the certificate ID
- Wrong validation regex for service.beta.kubernetes.io/do-loadbalancer-allow-rules HOT 2
- Feature Request: Create a Helm chart for DO CCM HOT 1
- Cloud Controller Manager doesn't add droplets to Load Balancer HOT 6
- `k8s.gcr.io` is no longer used HOT 2
- CI: Bypass branch protection on release workflow execution
- do-loadbalancer-allow-rules doesn't work (firewall is not configured) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from digitalocean-cloud-controller-manager.