Git Product home page Git Product logo

Comments (6)

ktecho avatar ktecho commented on September 25, 2024 1

so unless plebeian took interest in all my DMs

Indeed, that was the case :)

We'll show you all your Nostr private messages inside the "Private Messages" page in Plebeian Market. We cannot know if it's a personal message, or a message related to a product, so we'll show you all the messages.

from nos2x-fox.

diegogurpegui avatar diegogurpegui commented on September 25, 2024

Do you know what was the reason for the infinite loop?
I can imagine a site asking many permissions, but that would amount to a finite number of popups queued up. Why is that this particular site generated that infinite loop?

from nos2x-fox.

Giszmo avatar Giszmo commented on September 25, 2024

I'm not its developer but you wouldn't want more than a few popups per minute ever, so it would make sense to put mitigations in place for buggy sites as for malicious sites anyway.

from nos2x-fox.

diegogurpegui avatar diegogurpegui commented on September 25, 2024

Yeah that makes sense.
I was just wondering the underlying reason to see if there was a specific scenario we would want to account for and handle differently.

from nos2x-fox.

ktecho avatar ktecho commented on September 25, 2024

Hi.

The problem is that we're trying to decode all the Private Messages secuentially, and I think that makes the extension create one window to request permission for each of those messages. Nos2x also had this behaviour in the past, but they did improve the situacion and now only one window appears.

A few months ago I talked with a guy from Alby and they told me that they were trying to implement a queue or something like that, so you can request permission for the first message taken from the queue, and then you already have the permission set when taking the next messages...

from nos2x-fox.

Giszmo avatar Giszmo commented on September 25, 2024

I see it clearly as a bug on the extension side but I am sure I did not get more than a dozen messages from plebeian market but it was probably thousands of popups that opened, so unless plebeian took interest in all my DMs, it was not the decryption per event.

from nos2x-fox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.