Diablo Hellfire support about devilutionx HOT 112 CLOSED

All player classes are now fully implemented

from devilutionx.

Hellfire has now been merged and a menu has been build for it, at this point trying it out is as easy as:

cmake .. -DHELLFIRE=ON
make -j4

#876

from devilutionx.

We had a grate second hackathon, 64bit support is now done and the road ahead is more clear. Hellfire support is also well underway!

from devilutionx.

We can now load the game save state also, Hellfire support is now considered beta quality.

from devilutionx.

Diablo save games can now be loaded in Hellfire and Hellfire games can be loaded in Diablo. Items and game state is maintained when transferring the games (Hellfire specific items are lost when loading it's saves in Diablo).

from devilutionx.

Related to this issue, the GoG release now includes Hellfire (as of June 5, 2019): https://www.gog.com/game/diablo

from devilutionx.

Hellfire is now 99% integrated, stability issues have been solved, and the Cornerstone of The World is now functional.

Currently, Hellfire multiplayer heroes will morph when starting a new game, but this should be easy enough to solve.

Here is the first test build: https://15721-143324737-gh.circle-artifacts.com/0/devilutionx_x86.exe

from devilutionx.

I'd love to see hellfire support as well and I was going to ask about a donation button, too. I just discovered this project so I wish I could help. I'll see if I can make sense of the source and figure out how it works but this is all very new to me.

Also, thanks a ton for Devilution. It's so nice to be able to revisit Diablo!

from devilutionx.

I'd suggest joining discord for staying up to date :D also nice timing haha

from devilutionx.

Most stability issues have been fixed, all features are now implemented. 91% of the code has been properly integrated. Test builds will become available once we finish the remaining 9%.

from devilutionx.

Well just add a Sponsor button, I will gladly throw in some money for the Hellfire mod support.

Regarding a sponsor button, this has been discussed before. And to avoid any risk of associating Devilution with monetary gain the option of donations has been decided against. Thanks for the will to help out though!

Maybe your hackathon will have some beer included.

Haha, as the hackathon happens in Sweden we will most likely have tea and a cinnamon bun, proper FIka style!

from devilutionx.

Very excited for this. Thanks for all your hard work guys/girls.

from devilutionx.

Looks like most is being loaded correctly, but there are still some issues around items:

from devilutionx.

How do I unpack that file from "setup_diablo_1.09_hellfire_v2_(30038).exe"?

The exact same way as diabdat.mpq, but replace the file name with the 4 hellfire mpq names.
hellfire.mpq
hfmonk.mpq
hfmusic.mpq
hfvoice.mpq

from devilutionx.

hellfire.exe v1.01 has been completely mapped out in the scalpel repo, surprisingly there were very few functions added/changed. The DRLG code is just a slight hack of the original. Only complex part is all the new code for the missiles.

Sounds like a weekend hackathon to me! :)

from devilutionx.

Well just add a Sponsor button, I will gladly throw in some money for the Hellfire mod support.
Maybe your hackathon will have some beer included.

from devilutionx.

There you go

single_x.hsv.zip

from devilutionx.

New test-build: https://15745-143324737-gh.circle-artifacts.com/0/devilutionx_x86.exe

Notable changes:

• Oils are now fully integrated

The only missing part is a bit about how items are being picked up.

from devilutionx.

@Massi-Daisy
You can try install from PPA, for me work without error
https://launchpad.net/~devilutionx/+archive/ubuntu/dev

from devilutionx.

@Massi-Daisy there are some issues before hellfire gets fully integrated, this seems to be one of them

from devilutionx.

Ok things are stabilizing, all bugs should now be fixed and the only missing part is the support screen, here is a new fresh Windows build for anyone testing this:
https://16920-143324737-gh.circle-artifacts.com/0/devilutionx_x64.zip
Not that it is also 64bit now, something I would also like people to test to see if it's good enough for release :)

For Linux, Switch, Vita, 3DS, Amiga, and 32bit Windows please login here with github or build from master: https://app.circleci.com/pipelines/github/diasurgical/devilutionX/3160/workflows/a55919d4-5d57-4cd9-8268-a0ed5ed1bdd7

from devilutionx.

I'm not sure if this is DevilutionX / Hellfire related, but I'd like to share this issue with you.

I've tested the DevilutionX version that @AJenbo mentioned 2 days ago. Everything works fine - so far. I've imported my DevilutionX Diablo char by simple renaming the savegame from .sv to .hsv and started the first hellfire quest (Hive - The Defiler).

After defeating the mob "The Defiler" on Level Hive 4, the Quest "The Defiler" is still active and no needed cathedral map is dropping. I've searched for it in the entire level on every pixel but sadly it is not there. Even the quest "The Defiler" is still shown as active.

If this is a known bug with Hellfire itself, I'm sorry for writing these lines.

from devilutionx.

@Jarzuul thanks, I just did a quick fresh run where the quest definitely works, so this is probably related to converting a D1 game to HF, and I think I have a pretty good idea what the issue is.

from devilutionx.

#1057
Fast scrolling fixed

from devilutionx.

@mewmew Where in Sweden? ^^

Hi @MBeijer!

We are meeting up in Stockholm. If you happen to be close to the area, feel free to join the Devilution Fika Hackathon :)

Cheers,
Robin

from devilutionx.

@mewmew I'm relatively close and I travel to Stockholm pretty often. :) Would be fun to join up for a fika-hackaton!

We had a grate second hackathon, 64bit support is now done and the road ahead is more clear. Hellfire support is also well underway!

@MBeijer you are most welcome to join future hackathons :) Anders came up the last week to Stockholm and we did a lot of hacking together. This is but one of many fika hackathons we will be hosting :)

from devilutionx.

from devilutionx.

Yeah i figured it out, one of the buttons didn't require an account. They are on git hub now for future usage.

If you can compare that would be helpful, but just a screen shot of your stats and inventory in hellfire would be a bit help in it self :)

from devilutionx.

how about ingame so we see the full stats and items :)

from devilutionx.

Hellfire has its own mpq files you need to copy in addition to diabdat

from devilutionx.

The save game issues and stores have now been corrected:

(note world state is still not loaded)

from devilutionx.

@h3ct0r this is build from master, it's simply a link to the latest artifact on CircleCI so you can grab on for your system of choice there. I just put the link here as we get a lot of questions like this from windows users

from devilutionx.

Hi, I downloaded and compiled the source under Ubuntu 20.04. I absolutely LOVE being able to play Diablo 1 again (and now Hellfire too!), so thank you so much for making this happen!! <3

I thought you might appreciate the feedback... I created a monk, cleared the first level of the cathedral, went to town to pawn some stuff and buy a better staff from Griswold, heard what Lester had to say, and everything went well. Then I clicked on the entrance of the cathedral to go back down and this happened:

Segmentation fault (core dumped)

In fact, I seem to get a segfault and crash every time I exit and re-enter the cathedral on a new game. However, if I save and exit, and then load a saved game, I can go up and down multiple times without an issue, so at least that's a workaround :)

Rest assured that I'll be doing a lot more testing :D Thank you guys so much again, you're the best ever!!

from devilutionx.

When launching you have to give it the switches --bardtest --barbariantest. Whether that’s through terminal, a .sh script or adding it to the menu item.

from devilutionx.

yeah save games have known issues atm, this is probably also why you have crashes when changing levels as it reaads the save when doing so.

from devilutionx.

Amazing!! Thank you so much! I'll try the new version out as soon as I have time!

from devilutionx.

Amazing job guys!! Looks like scrolls are being preserved correctly in the belt now between saves. This was a quick test with a new monk and bard. I'll play some more (OK, a lot more) in the next days and let you know.
Thank you so much, and sorry again for being slow on the technical side of things. Kudos to all of you who made this!

from devilutionx.

@Massi-Daisy thanks for the quick test :)

I apologize, I guess I'm not very computer literate. I'm trying to figure out how the circleci page works. There was a list of architectures (I picked linux_x86_64), now I see a list of steps with outputs but I can't find a download link.

I am using the PPA that muzena gave me in this thread (https://launchpad.net/~devilutionx/+archive/ubuntu/dev). My package manager says that it's version 1.1.0.

The PPA appears to update once a day, the last build was 5 hours ago and the build was 2 hours ago, so the fix probably won't be available there until some time tomorrow.

The current version on the PPA is 1.1.0+git1478-732d070b-202102211933~ubuntu20.04.1, the third part (732d070b) is our developer version id (git hash), so that would be the part we would need in order to know what you are testing :)
Incidentally, the item fix is the only relevant part since that version.

from devilutionx.

I have tried this on my Switch, Vita and N3DSXL and it seems to be working pretty well :)

from devilutionx.

@spitfire nice, that good to have all 3 platforms confirmed :) Especially the Switch since it hasn't been tested for a bit.

from devilutionx.

I've been having a blast with my monk the last couple of days! The cathedral map dropped for me as expected, and I'm in the crypt right now.
The game is fully playable. I've only encountered two small cosmetic glitches so far (when Griswold gave me the Anvil of Fury quest, the text was scrolling way too quickly, and the listed damage for lightning wall is weird), but they don't impact gameplay at all. Fantastic job everybody!!

from devilutionx.

Ok, Hellfire multiplayer should now be fully working.

@spitfire upgrading your hero from D1 to Hellfire should now work correctly for the new quests (could you test this, with a hero that hasn't been upgraded).

Windows x86_64 build:
https://17247-143324737-gh.circle-artifacts.com/0/devilutionx_x64.zip
Linux x86_64 build:
https://17249-143324737-gh.circle-artifacts.com/0/devilutionx_linux_x86_64
Everything else:
https://app.circleci.com/pipelines/github/diasurgical/devilutionX/3193/workflows/1a36d2d5-1c47-4926-a9cd-457162635b4b

from devilutionx.

Yes, in the spellbook

Thanks, we were missing handling for the new spells (no new calculations were added, it simply reused existing calculations). The latest build should now match the numbers in the original game, not that these aren't actually related to the actual damage calculation. The number you were seeing previously was more or less random.

from devilutionx.

The game is fully playable. I've only encountered two small cosmetic glitches so far (when Griswold gave me the Anvil of Fury quest, the text was scrolling way too quickly, and the listed damage for lightning wall is weird), but they don't impact gameplay at all. Fantastic job everybody!!

I also had the text scroll real really fast, while narrator continued to speak - once in the give and second time in the crypt

Other than that haven't seen any issues

from devilutionx.

I finally found some time to compile git HEAD on my Gentoo box. Unfortunately, while testing Hellfire I get regular segfaults. Is this a known issue or would you appreciate if I compile again with debugging symbols and report these segfaults? If yes, any preferred way of reporting these?

from devilutionx.

Hi @mbreskovec

We probably will incorporate some of the changes from Hellfire (like map in town). The expansion issn't universally liked (especially not by the original developers). Most likely it will be added as a mod for DevilutionX once we get that going, it would form a pretty good proving grounds for that goal.

As for your question about translation, yes defiantly, i think we will aim for a multilingual program so that users can switch the language instead of the current solutions floating around out there where the exe has been hex edited to a specific language.
The only real limitation here is that the font in Diablo is ISO_8859-1 so there some limitations of how well different languages can be represented.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1#Modern_languages_with_complete_coverage

from devilutionx.

hellfire.exe v1.01 has been completely mapped out in the scalpel repo, surprisingly there were very few functions added/changed. The DRLG code is just a slight hack of the original. Only complex part is all the new code for the missiles.

from devilutionx.

@mewmew I'll come visit you for this one :D

from devilutionx.

Well then I'll have to show up and crash the party xDDDDDDDDD

from devilutionx.

@mewmew I'll come visit you for this one :D

Definitely!!

from devilutionx.

Well then I'll have to show up and crash the party xDDDDDDDDD

You are always welcome Andi! <3

from devilutionx.

@mewmew Where in Sweden? ^^

from devilutionx.

we will most likely have tea and a cinnamon bun, proper FIka style!

Oh, will Hallondricka be included as well? :P

I'll see if I can make sense of the source and figure out how it works but this is all very new to me.

Cool, would be great to have you join the project. Prepare for an addiction that leads to a gloomy fate and be bound by the chains of code archaeology!

I thought about working on Hellfire support. The issue was that a different compiler was used and some structs were dynamically allocated. We can probably ifdef this for the main project and include a separate .DSP for VC 5.10, but then that leaves the issue of being based on 1.04 vs. 1.07. Most of hellfire's code changes were trivial, with the addition of new missiles being the only complex part.

from devilutionx.

Cool, would be great to have you join the project. Prepare for an addiction that leads to a gloomy fate and be bound by the chains of code archaeology!

No promises but I'm already digging through the codebase. I've only recently picked up C++ for work and I know nothing about how Diablo or Hellfire behave but the source is interesting at least!

from devilutionx.

@galaxyhaxz I think it would be ok to have hellfire build on 1.09 even if not bin exact, or are you saying that it makes it harder to see what hellfire changed?

from devilutionx.

it makes it harder to see what hellfire changed?

Yeah basically. Not only do the changes between 1.04 and 1.07 have to be differentiated, but Sierra also released patch 1.01, which addressed many bugs including some that were fixed in 1.07. And it may have been done differently. More look at the code is needed before we decide, but hopefully we can add it to the base project.

EDIT: to clarify, the mechanic and bugfix for Mana shield is different.

We are meeting up in Stockholm

Is it going to be later this year? Not that I can attend sadly, still gotta do the whole 9 month passport thing lol. Would be super edgy though!!

from devilutionx.

Is it going to be later this year? Not that I can attend sadly, still gotta do the whole 9 month passport thing lol. Would be super edgy though!!

Yeah, the first of many Fika hackathons is in a few weeks/a month or two :)

from devilutionx.

@mewmew I'm relatively close and I travel to Stockholm pretty often. :) Would be fun to join up for a fika-hackaton!

from devilutionx.

Just stirring the pot a bit :) Has there been any recent developments on Hellfire support? If it gets added in, I'd love to try it out.

from devilutionx.

Awesome! Thanks for pointing this out!

from devilutionx.

https://discord.gg/aQBQdDe
:)

from devilutionx.

If anyone has some original Hellfire savegames they would be willing to donate then that would be very helpful for testing.

from devilutionx.

@spitfire any chance you can upload them here on github so i don't have to create a dropbox account :)

from devilutionx.

Any multiplayer saves out there :)

Should be called something like hrinfo_%d.drv

from devilutionx.

@spitfire you can now start new games using your existing Hellfire heros. Loading a save game will fail atm, and hellfire spell levels are set to 0. Could you verify the equipment and other hero stats are correct? I can already say that there are some issues with items but need to know what it is supposed to look like before I can easily correct it :)

from devilutionx.

@spitfire any chance you can upload them here on github so i don't have to create a dropbox account :)

Already had them on there and couldn't upload them again on mobile. They should be public and not require an account, did they?

@spitfire you can now start new games using your existing Hellfire heros. Loading a save game will fail atm, and hellfire spell levels are set to 0. Could you verify the equipment and other hero stats are correct? I can already say that there are some issues with items but need to know what it is supposed to look like before I can easily correct it :)

You mean I should try to load them in both Hellfire & devilutionX and compare?

from devilutionx.

These are the stats as seen with Hellfire 1.01 I was playing them on:

from devilutionx.

how about ingame so we see the full stats and items :)

from devilutionx.

The secound savegame you attached appears to be of your Spitfire rouge and not the Sledgehammer barbarian, pretty cool hero though :)

from devilutionx.

Attaching my characters straight from the game dir:

hsv.zip

from devilutionx.

@AJenbo
I compile DevilutionX with Hellfire support.
Then I extract "setup_diablo_1.09_hellfire_v2_(30038).exe" file.
I copied diabdat.mpq to /home/user/.local/share/diasurgical/devilution path.
diabdat.mpq extracted files from "setup_diablo_1.09_(27873).exe" and "setup_diablo_1.09_hellfire_v2_(30038).exe" files are the same size 517.5 MB.
setup_diablo_1.09_(27873).exe file has -> 674.9 MB.
setup_diablo_1.09_hellfire_v2_(30038).exe file has -> 850.1 MB.

When I tried to strat hellfire I get error like in this screenshot:

from devilutionx.

do you have hellfire mpq?

from devilutionx.

@qndel
I extract "setup_diablo_1.09_hellfire_v2_(30038).exe" file.
I copied diabdat.mpq to /home/user/.local/share/diasurgical/devilution path.
I extracted according to wiki instructions diabdat.mpq file

from devilutionx.

How do I unpack that file from "setup_diablo_1.09_hellfire_v2_(30038).exe"?

from devilutionx.

no idea

from devilutionx.

How do I unpack that file from "setup_diablo_1.09_hellfire_v2_(30038).exe"?

I don't have the gog version (this is what you have, right?). If you managed to extract it those files should be next to diabdat if your version does include hellfire.

from devilutionx.

Hi @AJenbo , is there any way to test this build in Linux? If the master HEAD is updated with these hellfire enhancements, I can try to compile the project. PD: Thanks for the hard work!

from devilutionx.

@h3ct0r
Which distro do you use?

from devilutionx.

Thank you, gonna try it now!

from devilutionx.

Btw, is there a way to enable the bard and barbarian supported yet? I found an .ini file in the diasurgical folder and tried adding random strings like "bardtest" and "barbariantest=1" but it didn't unlock the classes.
Not trying to rush you, just asking. I'm already ecstatic at this project as it is.

from devilutionx.

Thank you!
By the way, I still get the segfault + crash even with the package from the PPA. But the workaround still works so I'm happy.

from devilutionx.

@h3ct0r
Which distro do you use?

@muzena I'm using Xubuntu 16.04. I did manage to compile devilutionX after manually installing the latest libsodium version. I'm testing Hellfire right now!

from devilutionx.

Good masters, I have another strange experience to relate ;)

I went into town to sell some loot. Everything worked mostly as expected. However, the icons for the scrolls and the oils that I had just sold stayed in my inventory. The info box didn't display any text when I hovered the mouse pointer over them, and they poofed when I clicked on them. So this glitch seems to be purely cosmetic and doesn't seem to affect gameplay.

from devilutionx.

I have noticed that there is definitely something funky going on with scrolls, runes and oils. They have repeatedly disappeared from my inventory and belt (at least slot #8) between saves.
Still, amazing job everyone involved, keep up the awesome work!!

from devilutionx.

(Edit: Please disregard this post, I was using an outdated version)

Nope, I'm still having the bug with the scrolls disappearing from my belt between saves.

I downloaded and installed the updated package from the PPA, created a new monk, went to Adria to buy a healing scroll, put it into the eighth belt slot, saved the game, then loaded, and the scroll was gone. This happens reliably with the eighth slot, but occasionally with other slots too.
It's only with scrolls, runes and oils though, potions appear to be unaffected.

from devilutionx.

updated package from the PPA

I don't know what you are referring to, could you please test the official build that I linked to. At the very least give us the version of what you tested.

from devilutionx.

I apologize, I guess I'm not very computer literate. I'm trying to figure out how the circleci page works. There was a list of architectures (I picked linux_x86_64), now I see a list of steps with outputs but I can't find a download link.

I am using the PPA that muzena gave me in this thread (https://launchpad.net/~devilutionx/+archive/ubuntu/dev). My package manager says that it's version 1.1.0.

from devilutionx.

Never mind, found it under "Artifacts". Will download and install now.

from devilutionx.

@AJenbo Thanks for your quick reply. If I can support you with my savegame please let me know :)

from devilutionx.

the listed damage for lightning wall is weird

in the spellbook? Could you let me know what it is and what it should be?

from devilutionx.

Yes, in the spellbook. According to diablo.fandom.com (and Jarulf's), the min damage should be 4 + 2 * clvl, and the max should be 40 + 2 * clvl.

In the spellbook, from the moment I got the spell until now (I've gained plenty of levels in the meantime) the min has been listed as some ridiculous number in excess of 22000. The max is listed as 0 unless my cursor hovers over the "Spells" or "Inv" buttons, in which case it becomes something around 170. I think the exact values have been changing a little with levels. If you want, I can start a new playthrough, try to get the spell as early as possible, and tabulate the exact numbers I get for each clvl.

I have used the spell against the torchants in the Nest and it kills them about as fast as I would expect, so I'm sure the damage is calculated correctly, and the bug is just a visual one.

I'll be very happy to download the new version and play around with multiplayer too :) I can't thank you enough for this!!

from devilutionx.

Fantastic, thank you! Can't wait to play the new version tonight :D

from devilutionx.

@Massi-Daisy did the text scrolling it look like this?: #1046

from devilutionx.

@Massi-Daisy did the text scrolling it look like this?: #1046

Yes! So far it has only happened to me with the Anvil of Fury quest. Other quests were behaving normally, as were the tomes on levels 4 and 8. I haven't reached level 12 of the caves yet.

from devilutionx.

On Ubuntu 20.04, I only ever got a segfault twice. On both occasions it was on a new game, without having made a savefile, when I came back to town from the cathedral. Saving my game before changing maps fixed the issue.

from devilutionx.

I finally found some time to compile git HEAD on my Gentoo box. Unfortunately, while testing Hellfire I get regular segfaults. Is this a known issue or would you appreciate if I compile again with debugging symbols and report these segfaults? If yes, any preferred way of reporting these?

ofcause, create github issues

from devilutionx.

Ok, Hellfire multiplayer should now be fully working.

@spitfire upgrading your hero from D1 to Hellfire should now work correctly for the new quests (could you test this, with a hero that hasn't been upgraded).

Windows x86_64 build:
https://17247-143324737-gh.circle-artifacts.com/0/devilutionx_x64.zip
Linux x86_64 build:
https://17249-143324737-gh.circle-artifacts.com/0/devilutionx_linux_x86_64
Everything else:
https://app.circleci.com/pipelines/github/diasurgical/devilutionX/3193/workflows/1a36d2d5-1c47-4926-a9cd-457162635b4b

Hey @AJenbo

I'm not sure if you wanted to mention me instead of spitfire, but I've tried the new build with a Devilution D1 Char. After starting a "New Game" I'm sadly have the same issues. Defiler Quest is not ending and the cathedral map is not dropping.

from devilutionx.

Could you provide a save.

from devilutionx.

@AJenbo

I've just sent you an email with attached savegames. Thank you, Anders!

from devilutionx.

@AJenbo

I've just sent you an email with attached savegames. Thank you, Anders!

An email? Sigh ... Why not attach them here so everyone can test? :(

from devilutionx.